Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENM node and edge counts should be counted after merging imports #99

Open
jmillanacosta opened this issue Oct 1, 2024 · 2 comments
Open

Comments

@jmillanacosta
Copy link

Hi, I came across this project and saw this:

image

The eNM ontology uses owl imports and you are probably only capturing the ontology annotations.

@caufieldjh
Copy link
Collaborator

Hi @jmillanacosta - excellent point! The transforms are not currently doing anything with imports, though the corresponding Bioportal page shows all base and imported classes. There are certainly positives and negatives about including imports, with one positive being that application ontologies like ENM will look much more complete with imports vs. without. In this case I can use one of the alternate serializations of the ontology as they contain the imported classes.

@jmillanacosta
Copy link
Author

Hi @caufieldjh, thank you for your explanation, I think that's a good rule of thumb for application ontologies. However, we import a few hundred internally developed classes into the main enanomapper.owl class hierarchy that we would like to see reflected in the KG stats. I can get back to you soon when the next release is out to discuss which subset works better for this KG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants