Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Nextflow target Java to version 17 #5211

Closed
pditommaso opened this issue Aug 7, 2024 · 0 comments · Fixed by #5045
Closed

Upgrade Nextflow target Java to version 17 #5211

pditommaso opened this issue Aug 7, 2024 · 0 comments · Fixed by #5045

Comments

@pditommaso
Copy link
Member

The goal of this PR is to increase the Java language and runtime compatibility to Java 17.

nextflow/build.gradle

Lines 75 to 82 in 2a71206

compileJava {
options.release.set(11)
}
tasks.withType(GroovyCompile) {
sourceCompatibility = '11'
targetCompatibility = '11'
}

This was attempted in #5045 however it turns out the Spock tests depends either of gclib or Bytebuddy for bytecode manipulation.

The first does not work on Java 17 (and it's not maintained anymore), the second cause some tests to fail.

The goal of this PR is to solve the dependency issue and allow targeting Java 17

@bentsherman bentsherman linked a pull request Sep 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant