-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIs containing brown nodes not protected in early commits. #17
Comments
What corrective action, if any, is required before the pull request can be submitted? |
Password protection needs to remain enabled if there are private properties, unless we decide to make them public, which wont happen right away. According to @gregr-ni, an option would be to implement the functionality without the use of brown nodes. |
That has always been my understanding, and passwords are in place on all of the relevant VIs at this time. Per my original statement of this issue, what, if anything, do I need to do about the earlier commits in my fork where passwords were not enabled? |
Once i create the new branch, fork the repo, and on your fork, checkout the new branch. After that, go to the commits on source tree that you want to bring to your new branch (avoiding the ones that have password protection) and press "cherry pick" on each. You can then submit a pull request from the new branch on your fork, to the new branch from our repo. |
The history for a soon-to-be-made pull request contains early commits of VIs that should be password-protected, but which had their protection removed to allow for the backport.
After the pull request is accepted, it will be possible for third parties to download the repository and access those protected block diagrams by simply reverting to those earlier commits.
The text was updated successfully, but these errors were encountered: