Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add" button on basal profile screen disappears when an 11:30 pm basal segment is added #428

Open
dsut4392 opened this issue Oct 10, 2024 · 6 comments
Labels
bug Something isn't working needs-triage

Comments

@dsut4392
Copy link

Describe the bug

*When you add a basal segment commencing at 11:30pm, the "Add" button disappears and you are unable to add any further basal segments, regardless of start time. Work-around: Deleting the 11:30pm segment (or editing the start time to an earlier time) re-enables the add button, allowing you to create new basal segment. *

Attach a Log

see video

To Reproduce

Steps to reproduce the behaviour:

  1. Go to 'Settings - Basal Profile'
  2. Click on 'Add' to create a new basal segment, or edit an existing basal segment to start at 11:30pm
  3. Scroll down to '....'
  4. See error

Expected behaviour

*If there are basal start times that are unallocated (i.e. between 00:00 and 11:30pm, setting a basal segment start time at 11:30pm should not prevent you from creating earlier ones.*

Screenshots

If applicable, add screenshots to help explain your problem.

Setup Information (please complete the following information):

Smartphone:

  • Hardware: * iPhone 15 Pro Max]*
  • OS Version: iOS 17.7

Pump:

  • Any - confirmed on Dash and Simulator

Trio Version:

  • Version Number: 0.2.1 main
  • Repo: nightscout/trio
@dsut4392 dsut4392 added bug Something isn't working needs-triage labels Oct 10, 2024
@dsut4392
Copy link
Author

RPReplay_Final1728537744.mp4

@Sjoerd-Bo3
Copy link
Contributor

Would be nice if the add button would appear in between possible segments right? So instead of an add button on the bottom, it will appear in between entries that are more than 0:30 apart?

Or an add button on top and a dialog before adding it to the list?

Or would this be awful? Just a first thought? Any other recommendations?

@dsut4392
Copy link
Author

From this FB post: https://www.facebook.com/groups/diytrio/posts/1685489575518224

I don't think this really needs fixing in 0.2.1, the workaround is probably enough until 1.0 is released?

@Sjoerd-Bo3
Copy link
Contributor

This is not ‘fixed’ in 1.0 either. It’s better, but your ‘issue’ is still not possible and needs the same work around.

Copy link

hey 👋 - no triage is done for 30 days 🤐 ... anybody? triage is required!

@github-actions github-actions bot added the stale label Nov 10, 2024
@marionbarker
Copy link
Contributor

Bump

@github-actions github-actions bot removed the stale label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
Status: No status
Development

No branches or pull requests

3 participants