From a4179e01f32c6a6194c21334635a66616f265447 Mon Sep 17 00:00:00 2001 From: Chengzhong Wu Date: Mon, 1 Jul 2024 10:38:22 +0100 Subject: [PATCH] chore: fix XCConfigurationList assertion --- .github/workflows/node-gyp.yml | 5 ++--- .github/workflows/nodejs.yml | 4 +--- .github/workflows/python_tests.yml | 3 +-- pylib/gyp/xcodeproj_file.py | 2 +- 4 files changed, 5 insertions(+), 9 deletions(-) diff --git a/.github/workflows/node-gyp.yml b/.github/workflows/node-gyp.yml index b960fcf..4382979 100644 --- a/.github/workflows/node-gyp.yml +++ b/.github/workflows/node-gyp.yml @@ -1,12 +1,11 @@ name: node-gyp integration on: push: - branches: [ main ] pull_request: - branches: [ main ] workflow_dispatch: + jobs: - integration: + node-gyp-integration: strategy: fail-fast: false matrix: diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 3056897..53935d4 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -1,13 +1,11 @@ name: Node.js integration on: push: - branches: [ main ] pull_request: - branches: [ main ] workflow_dispatch: jobs: - integration: + nodejs-integration: strategy: fail-fast: false matrix: diff --git a/.github/workflows/python_tests.yml b/.github/workflows/python_tests.yml index 1140ef2..507d4d2 100644 --- a/.github/workflows/python_tests.yml +++ b/.github/workflows/python_tests.yml @@ -4,10 +4,9 @@ name: Python_tests on: push: - branches: [ main ] pull_request: - branches: [ main ] workflow_dispatch: + jobs: Python_tests: runs-on: ${{ matrix.os }} diff --git a/pylib/gyp/xcodeproj_file.py b/pylib/gyp/xcodeproj_file.py index 4f92cd0..cb4d0d2 100644 --- a/pylib/gyp/xcodeproj_file.py +++ b/pylib/gyp/xcodeproj_file.py @@ -781,7 +781,7 @@ def UpdateProperties(self, properties, do_copy=False): # Make sure the property conforms to the schema. (is_list, property_type, is_strong) = self._schema[property][0:3] if is_list: - if not isinstance(value.__class__, list): + if not isinstance(value, list): raise TypeError( property + " of "