From ca8b28596cb4b1c6e4434b76abd135cb9ae7818a Mon Sep 17 00:00:00 2001
From: Nicola Fontana <ntd@entidi.it>
Date: Wed, 21 Sep 2016 19:52:53 +0200
Subject: [PATCH 1/5] Add HiddenField template

---
 templates/forms/HiddenField.ss | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 templates/forms/HiddenField.ss

diff --git a/templates/forms/HiddenField.ss b/templates/forms/HiddenField.ss
new file mode 100644
index 0000000..9043664
--- /dev/null
+++ b/templates/forms/HiddenField.ss
@@ -0,0 +1 @@
+<input $AttributesHTML>

From 1c455b5fa3c2f7b04ee3b3b9d6f384667b2adf1a Mon Sep 17 00:00:00 2001
From: helpfulrobot <chris@silverstripe.com>
Date: Wed, 17 Feb 2016 03:20:31 +1300
Subject: [PATCH 2/5] Added standard Scrutinizer config

---
 .scrutinizer.yml | 69 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 .scrutinizer.yml

diff --git a/.scrutinizer.yml b/.scrutinizer.yml
new file mode 100644
index 0000000..d1ebd80
--- /dev/null
+++ b/.scrutinizer.yml
@@ -0,0 +1,69 @@
+inherit: true
+
+checks:
+  php:
+    verify_property_names: true
+    verify_argument_usable_as_reference: true
+    verify_access_scope_valid: true
+    useless_calls: true
+    use_statement_alias_conflict: true
+    variable_existence: true
+    unused_variables: true
+    unused_properties: true
+    unused_parameters: true
+    unused_methods: true
+    unreachable_code: true
+    too_many_arguments: true
+    sql_injection_vulnerabilities: true
+    simplify_boolean_return: true
+    side_effects_or_types: true
+    security_vulnerabilities: true
+    return_doc_comments: true
+    return_doc_comment_if_not_inferrable: true
+    require_scope_for_properties: true
+    require_scope_for_methods: true
+    require_php_tag_first: true
+    psr2_switch_declaration: true
+    psr2_class_declaration: true
+    property_assignments: true
+    prefer_while_loop_over_for_loop: true
+    precedence_mistakes: true
+    precedence_in_conditions: true
+    phpunit_assertions: true
+    php5_style_constructor: true
+    parse_doc_comments: true
+    parameter_non_unique: true
+    parameter_doc_comments: true
+    param_doc_comment_if_not_inferrable: true
+    optional_parameters_at_the_end: true
+    one_class_per_file: true
+    no_unnecessary_if: true
+    no_trailing_whitespace: true
+    no_property_on_interface: true
+    no_non_implemented_abstract_methods: true
+    no_error_suppression: true
+    no_duplicate_arguments: true
+    no_commented_out_code: true
+    newline_at_end_of_file: true
+    missing_arguments: true
+    method_calls_on_non_object: true
+    instanceof_class_exists: true
+    foreach_traversable: true
+    fix_line_ending: true
+    fix_doc_comments: true
+    duplication: true
+    deprecated_code_usage: true
+    deadlock_detection_in_loops: true
+    code_rating: true
+    closure_use_not_conflicting: true
+    catch_class_exists: true
+    blank_line_after_namespace_declaration: false
+    avoid_multiple_statements_on_same_line: true
+    avoid_duplicate_types: true
+    avoid_conflicting_incrementers: true
+    avoid_closing_tag: true
+    assignment_of_null_return: true
+    argument_type_checks: true
+
+filter:
+  paths: [code/*, tests/*]

From 6a2998b062d3adc42cbff714915b52a8df5e93c7 Mon Sep 17 00:00:00 2001
From: helpfulrobot <chris@silverstripe.com>
Date: Fri, 1 Jan 2016 04:23:35 +1300
Subject: [PATCH 3/5] Added standard .editorconfig file

---
 .editorconfig | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 .editorconfig

diff --git a/.editorconfig b/.editorconfig
new file mode 100644
index 0000000..47ae637
--- /dev/null
+++ b/.editorconfig
@@ -0,0 +1,17 @@
+# For more information about the properties used in this file,
+# please see the EditorConfig documentation:
+# http://editorconfig.org
+
+[*]
+charset = utf-8
+end_of_line = lf
+indent_size = 4
+indent_style = space
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+[{*.yml,package.json}]
+indent_size = 2
+
+# The indent size used in the package.json file cannot be changed:
+# https://github.com/npm/npm/pull/3180#issuecomment-16336516

From 95d5536398e1802bba9a8d504a602b03ad73560e Mon Sep 17 00:00:00 2001
From: Nicola Fontana <ntd@entidi.it>
Date: Fri, 30 Sep 2016 18:50:08 +0200
Subject: [PATCH 4/5] Make $messageType compatible with bootstrap

SilverStripe typically sets it to good, bad of warning but Bootstrap
expects the class alert-success, alert-danger or alert-warning.
---
 templates/Includes/Form.ss | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/Includes/Form.ss b/templates/Includes/Form.ss
index 148520b..82e38e4 100644
--- a/templates/Includes/Form.ss
+++ b/templates/Includes/Form.ss
@@ -1,6 +1,6 @@
 <% if $IncludeFormTag %>
 <form class="form-horizontal $extraClass" $getAttributesHTML('class') role="form"><% end_if %><% if $Message %>
-  <div id="{$FormName}_error" class="alert $MessageType">
+  <div id="{$FormName}_error" class="alert alert-<% if $MessageType='good' %>success<% else_if $MessageType='bad' %>danger<% else %>warning<% end_if %>">
     <button type="button" class="close" data-dismiss="alert">&times;</button>
     $Message
   </div><% else %>

From 140871bea05fd303e8a6b4d2c5f797824f8b4415 Mon Sep 17 00:00:00 2001
From: Nicola Fontana <ntd@entidi.it>
Date: Wed, 14 Jun 2017 23:45:18 +0200
Subject: [PATCH 5/5] Allow disabling of SelectionGroup

When a SilverstrapSelectionGroup is disabled, add the class .disabled to
all the <li> items.
---
 templates/forms/SelectionGroup.ss | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/templates/forms/SelectionGroup.ss b/templates/forms/SelectionGroup.ss
index ff0e082..681811a 100644
--- a/templates/forms/SelectionGroup.ss
+++ b/templates/forms/SelectionGroup.ss
@@ -1,7 +1,7 @@
 <input type="hidden" name="$Name.ATT" value="$Value.ATT">
 <ul class="nav nav-pills<% if extraClass %> $extraClass<% end_if %>"><% loop $FieldSet %>
-  <li role="presentation"<% if $Selected || $Up.IsReadonly %> class="<% if $Selected %>active<% end_if %> <% if $Up.IsReadOnly %>disabled<% end_if %>"<% end_if %>>
-    <a href="#$Up.Name.ATT-$Pos" aria-controls="$Up.Name.ATT-$Pos" role="tab" data-toggle="tab" data-value="$value.ATT">$Title</a>
+  <li role="presentation"<% if $Selected || $Up.IsReadonly || $Up.IsDisabled%> class="<% if $Selected %>active<% end_if %> <% if $Up.IsReadonly || $Up.IsDisabled %>disabled<% end_if %>"<% end_if %>>
+    <a href="#$Up.Name.ATT-$Pos" aria-controls="$Up.Name.ATT-$Pos" role="tab" data-toggle="tab" data-value="$value.ATT">$Title.XML</a>
   </li><% end_loop %>
 </ul>
 <div class="tab-content"><% loop $FieldSet %>