Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package test command fails if phpunit.xml file does not exist #274

Open
KarinaRashchynskaya opened this issue May 5, 2023 · 0 comments
Open

Comments

@KarinaRashchynskaya
Copy link

Hello,

I would like to recommend a possible feature in terms of package:test --parallel command. I noticed that in your latest updates, you add an extra functionality in terms of caching which requires loading the proper phpunit.xml file (6fc0c47).

However, the code enforces the file's path, considering that by default it would be in the laravel's base path.
Although, there are external packages which extend your class and their configurations files (phpunit.xml) have different paths or maybe do not exist.

So, my suggestion is, to let others to overwrite the required file (if they want).
I was thinking a solution like this :

#273

The above, will help external packages, which extend the nunomaduro/collision, to keep execute package:test --parallel command on their own configuration options.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant