Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]ipmitool sensor cannot present correct values #198

Open
justin0309 opened this issue Nov 22, 2023 · 0 comments
Open

[Bug]ipmitool sensor cannot present correct values #198

justin0309 opened this issue Nov 22, 2023 · 0 comments

Comments

@justin0309
Copy link

justin0309 commented Nov 22, 2023

When I set CRITLO_temp1 to negative numbers in the conf under phosphor-hwmon, the correct values ​​are displayed on dbus, but values ​​less than 0 cannot be displayed through the ipmitool sensor.
The result of my own experiment is that when the value is less than 0, it will be set to 0.

image
image

In addition, I set the values ​​of MINVALUE_temp1 and MAXVALUE_temp1 but non-Recoverable still shows NA.

Because our temperature threshold supports negative numbers, it seems that it is because the type of param lowerCritical is uint8_t. Even if the type set in ipmi sensor.yaml is double, no negative numbers will be generated.
[ * @param lowerCritical - Lower critical threshold](https://github.com/openbmc/phosphor-host-ipmid/blob/68d9d40530351e3f3db2c00a25969b0efc9fbe3f/sensorhandler.cpp#L787)](https://github.com/openbmc/phosphor-host-ipmid/blob/68d9d40530351e3f3db2c00a25969b0efc9fbe3f/sensorhandler.cpp#L787)

@justin0309 justin0309 changed the title [Bug]ipmitool sensor cannot present correct values [Bug]ipmitool sensor Oct 7, 2024
@justin0309 justin0309 changed the title [Bug]ipmitool sensor [Bug]ipmitool sensor cannot present correct values Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant