Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Test Password with the wrong length is throwing the error code 0xc7 instead of 0x81 #204

Open
Mani-v opened this issue May 9, 2024 · 2 comments

Comments

@Mani-v
Copy link

Mani-v commented May 9, 2024

As pre-Intel specification document session 22.30 Set User Password command pointing to Table 22-35 mandatory response Data expected is 81h for password test failed with wrong password size.

Response needs to be pointing to ipmiCCPasswdFailWrongSize = 0x81 error code, but with the current code base its responding as 0xc7

Is there a particular rationale for departing from the IPMI specification and opting for generic error codes instead, specifically for cases like "Request data length invalid (C7h)" as outlined in Table 5-2: Completion Codes?

@williamspatrick
Copy link
Member

Can you submit a fix in Gerrit? It's probably just an oversight or mistake in the implementation.

@lxwinspur
Copy link
Contributor

Can you submit a fix in Gerrit? It's probably just an oversight or mistake in the implementation.

@Mani-v fixed: https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/73068
Could you please review this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants