Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update direction example is broken #31

Open
fabianp opened this issue Mar 10, 2020 · 5 comments
Open

Update direction example is broken #31

fabianp opened this issue Mar 10, 2020 · 5 comments
Assignees

Comments

@fabianp
Copy link
Member

fabianp commented Mar 10, 2020

The example
https://github.com/openopt/copt/blob/master/examples/frank_wolfe/plot_vertex_overlap.py

(see output here )

does not produce the expected output.

@gideonite: do you want to take a look into it? This looks like a good issue to get familiar with the codebase

@gideonite
Copy link
Collaborator

Yes, interesting. I'll check it out! Sorry, somehow I missed that I was tagged in this issue! Feel free to assign to me.

@fabianp
Copy link
Member Author

fabianp commented Mar 29, 2020

awesome, assigned

@GeoffNN
Copy link
Collaborator

GeoffNN commented Jun 19, 2020

Has this been fixed?

For away/pairwise, it would also be interesting to see the results. For pairwise, we may need to store the pair of vertices that are chosen.

@GeoffNN
Copy link
Collaborator

GeoffNN commented Jun 19, 2020

Shouldn't the overlap go back to 0 every time we change chosen vertex? Or are we plotting the cumulative sum right now?

@gideonite
Copy link
Collaborator

gideonite commented Jun 19, 2020

I tried to fix this in #34. I think it's the cumulative sum, see https://github.com/openopt/copt/blob/master/examples/frank_wolfe/plot_vertex_overlap.py#L56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants