Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the pools package #3764

Open
p0mvn opened this issue Aug 19, 2024 · 0 comments
Open

delete the pools package #3764

p0mvn opened this issue Aug 19, 2024 · 0 comments

Comments

@p0mvn
Copy link
Member

p0mvn commented Aug 19, 2024

          This is a good cleanup step.

Without spending tons of time digging into the code, I think the next step to evetually delete the pools package (or help us be ready to) would be to copy over any imports directly from the pools package into /packages/server/src/queries/sidecar/router.ts (like error types, the router interface, etc).

Basically removing references into the pools package. Then when the tRPC migration is complete and all legacy pools queries are deleted, we can just delete that package in entirety.

Originally posted by @jonator in #3757 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant