Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 7.0.0 #10373

Open
50 of 87 tasks
ScharfViktor opened this issue Oct 22, 2024 · 20 comments
Open
50 of 87 tasks

Release 7.0.0 #10373

ScharfViktor opened this issue Oct 22, 2024 · 20 comments
Milestone
Release 7.0.0

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Oct 22, 2024 •
edited
Loading

Beta Phase

  • DEV/QA: Kickoff meeting Kickoff meeting
  • DEV/QA: Define client versions and provide list of breaking changes for desktop/mobile team
    • desktop 5.3.1
    • android 4.4.0
    • iOS 12.3.1
  • DEV/QA: Check new strings and align with clients
  • DEV: envvars
    • Cleanup of all envvars with deprecations (deprecationVersion/ removalVersion)
    • Update all ennvars with introductionVersion: '%%NEXT%%' --> 7.0.0
    • Create/merge updated envvar helper yaml files
  • DEV/DOCS: Create list of pending docks tasks
  • DEV: Create branch release-7.0.0-rc.1 -> FEATURE FREEZE
    • DEV: bump ocis version in necessary files
    • DEV: changelog/CHANGELOG.tmpl
    • DEV: ocis-pkg/version/version.go
    • DEV: sonar-project.properties
    • DEV: prepare changelog folder in changelog/7.0.0-rc.1_2024-11-0 7
  • DEV: Check successful CI run on release branch
  • DEV: Create signed tag 7.0.0-rc.1
  • DEV: Check successful CI run on 7.0.0-rc.1 tag / BLOCKING for all further activity
  • DEV: Merge back rc.1 release branch
  • DEV: https://ocis.team.owncloud.works/
    • DEV: needs snapshot and migration
  • Create list of changed ENV vars from 5.0 to 7.0
  • Create Migration Documentation @mmattel

QA Phase

Extra QA Topics

Standard QA

After QA Phase

  • Brief company-wide heads up via mail
  • DEV: Create list of changed ENV vars and send to release-coordination@owncloud.com
    • Variable Name
    • Introduced in version
    • Default Value
    • Description
    • dependencies with user other components
  • DEV: Create branch release-x.x.x
    • DEV: bump ocis version in necessary files
    • DEV: ocis-pkg/version/version.go
    • DEV: sonar-project.properties
    • DEV: released deployment versions
    • DEV: prepare changelog folder in changelog/x.x.x_???
  • Release Notes + Breaking Changes
  • Migration + Breaking Changes Admin Doc @mmattel
  • Migration + Breaking Changes Helm Chart Doc @mmattel
  • DEV: Create final signed tag
  • DEV: Check successful CI run on vx.y.z tag / BLOCKING for all further activity
  • Merge release notes

Post-release communication

  • DEV: Create a docs-stable-x.y branch based on the docs folder in the ocis repo @micbar
  • DEV: Create a x.y.z release in the ocis-helm repo (frozen state) @wkloucek
  • DEV/QA: Ping documentation in RC about the new release tag (for ocis/helm chart version bump in docs)
  • DEV/QA: Ping marketing to update all download links (download mirrors are updated at the full hour, wait with ping until download is actually available)
  • DEV/QA: Ping the demo instances are running this release
  • DEV/QA: notify to publish client finals
  • DEV: Merge back release branch
  • DEV: Create stable-x.y branch in the ocis repo from final tag
@ScharfViktor ScharfViktor added this to the Release 7.0.0 milestone Oct 22, 2024
@ScharfViktor ScharfViktor pinned this issue Oct 22, 2024
@saw-jan saw-jan mentioned this issue Oct 23, 2024
Open
@JammingBen
Copy link
Contributor

Breaking changes for administrators in since Web version 8:

There are more breaking changes for developers, however they are not noteworthy when just updating oCIS (Web).

@mmattel
Copy link
Contributor

mmattel commented Oct 23, 2024 •
edited
Loading

  • Deprecated config options have been removed

@JammingBen
Q: when looking into the referenced web PR, options have been removed - ok.
But are there any web service options related to the ocis repo that are now gone too?
In other words, how are the removed web options relevant for the ocis repo/admin if he cant set them?
Or did I miss something?

@JammingBen
Copy link
Contributor

Q: when looking into the referenced web PR, options have been removed - ok.
But are there any web service options related to the ocis repo that are now gone too?
In other words, how are the removed web options relevant for the ocis repo/admin if he cant set them?
Or did I miss something?

The admin can set them via the web config file. It's not really breaking anything though, setting them did basically nothing. So this is listed just for sake of completeness.

@mmattel mmattel mentioned this issue Oct 24, 2024
Draft
@micbar
Copy link
Contributor

micbar commented Oct 25, 2024

@kobergj @mmattel @dragonchaser

We need to create a migration guide from 5.0 to 7.0. Something like https://doc.owncloud.com/ocis/5.0/migration/upgrading_4.0.0_5.0.0.html

Please collect all breaking changes.

CHANGES

@mmattel
Copy link
Contributor

mmattel commented Oct 25, 2024

We need to create a migration guide from 5.0 to 7.0.

@ScharfViktor anything found so far with your tests?

@mmattel
Copy link
Contributor

mmattel commented Oct 25, 2024

@ScharfViktor pls see ocis init --diff to get a delta for config changes between versions.

@ScharfViktor ScharfViktor mentioned this issue Oct 25, 2024
Open
@ScharfViktor
Copy link
Contributor Author

Please collect all breaking changes.

I created issue for that #10416

@ScharfViktor
Copy link
Contributor Author

Upgrade test with app-provider between owncloud/ocis:5.0 (uses cs3org/wopiserver) and owncloud/ocis-rolling:6.6.1 (uses new colaboration service)

Steps:
git checkout stable-5.0
mkdir /yourPath/ocis-upgradeTest
mkdir /yourPath/ocis-upgradeTest/config
mkdir /yourPath/ocis-upgradeTest/data
cd ocis/deployments/examples/ocis_wopi
enable onlyoffice..env-> 204 line
OCIS_CONFIG_DIR=/Users/scharfviktor/ocis-upgradeTest/config OCIS_DATA_DIR=/Users/scharfviktor/ocis-upgradeTest/data OCIS_DOCKER_TAG=5.0 docker compose up -d
-- create data -- see checklist
docker compose down
git checkout master (v6.6.1)
cd ocis/deployments/examples/ocis_full
enable onlyoffice. .env -> 204 line
OCIS_CONFIG_DIR=/Users/scharfviktor/ocis-upgradeTest/config OCIS_DATA_DIR=/Users/scharfviktor/ocis-upgradeTest/data OCIS_DOCKER_TAG=6.6.1 OCIS_DOCKER_IMAGE=owncloud/ocis-rolling docker compose up -d
-- check created data --

Result: all data are exist. collabora and onlyoffice have been started but cannot be opened

image

ocis_full-collaboration-1 has: (ocis_full-collaboration-oo-1 hasn't log) :
The WOPI secret has not been set properly in your config for collaboration. Make sure your /etc/ocis config contains the proper values (e.g. by running ocis init or setting it manually in the config/corresponding environment variable).

Solution:

  • add COLLABORATION_WOPI_SECRET: "some-wopi-secret-onlyoffice" to onlyoffice.yml->collaboration-oo->enviroment and collabora.yml->collaboration->enviroment
  • restart docker compose: OCIS_CONFIG_DIR=/Users/scharfviktor/ocis-upgradeTest/config OCIS_DATA_DIR=/Users/scharfviktor/ocis-upgradeTest/data OCIS_DOCKER_TAG=6.6.1 OCIS_DOCKER_IMAGE=owncloud/ocis-rolling docker compose up -d

Result: works. added to #10416

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Oct 29, 2024 •
edited
Loading

Smoke test: ocis with ldap:

Preparation

Test

  • upgrade ocis to new version OCIS_CONFIG_DIR=/Users/scharfviktor/ocis-upgradeTest/config OCIS_DATA_DIR=/Users/scharfviktor/ocis-upgradeTest/data OCIS_DOCKER_TAG=6.6.1 OCIS_DOCKER_IMAGE=owncloud/ocis-rolling docker compose up -d

❌️ FAIL - after the update all created users and groups are gone. Need ask @rhafer - fixed here #10457

  • check that
    • created demo users and group still exist
    • created ldap users user1 and group group1 still exist
    • users user1 can log in
    • deleted group philosophy-haters and user marie doesn't exist
    • richard user still disabled and cannot log in
  • using ldap client https://ldap.owncloud.test/
    • create new ldap user user2
    • create new ldap group group2
    • add new user user2 to group group1 and group2
  • new user user2 can log in
  • log in as einstein
    • try to find sharees by user and by group
  • using ldap client https://ldap.owncloud.test/
    • disable user user1, user2, einstein
    • delete physics-lovers, group1, group2, einstein, user1, user2, richard

@ScharfViktor ScharfViktor mentioned this issue Nov 4, 2024
Merged
@saw-jan
Copy link
Member

saw-jan commented Nov 5, 2024

  • QA: against mac - smoke test

We need someone who can do desktop client smoke test on Mac. Test cases are here

CC @ScharfViktor

@ScharfViktor
Copy link
Contributor Author

We need someone who can do desktop client smoke test on Mac.

I'll take care

@nirajacharya2
Copy link
Contributor

Smoke Test with Web Office

Collabora

  • Spreadsheet

    • Create
    • Open
    • Open with two users in collaboration mode and read-only
    • Open with two users in collaboration mode and write access

  • Document

    • Create
    • Open
    • Open with two users in collaboration mode and read-only
    • Open with two users in collaboration mode and write access

  • Presentation

    • Create
    • Open
    • Open with two users in collaboration mode and read-only
    • Open with two users in collaboration mode and write access

Onlyoffice

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Nov 5, 2024 •
edited
Loading

Ms office:
Spreadsheet

  • Create
  • Open
  • Open with two users in collaboration mode and read-only
  • Open with public in collaboration mode and read-only
  • Open with two users in collaboration mode and write access
  • Open with public in collaboration mod and write access

Document

  • Create
  • Open
  • Open with two users in collaboration mode and read-only
  • Open with public in collaboration mode and read-only
  • Open with two users in collaboration mode and write access
  • Open with public in collaboration mod and write access

Presentation

  • Create
  • Open
  • Open with two users in collaboration mode and read-only
  • Open with public in collaboration mode and read-only
  • Open with two users in collaboration mode and write access
  • Open with public in collaboration mod and write access

Notice: I can create .pptx but cannot open it. https://pus4-powerpoint.officeapps.live.com/pods/PowerPoint.ashx?boot=true hangs for 1 min and is interrupted by
image

@micbar
Copy link
Contributor

micbar commented Nov 5, 2024

@ScharfViktor i know that problem. PowerPoint cannot deal with 0 byte files.

@ScharfViktor
Copy link
Contributor Author

@ScharfViktor i know that problem. PowerPoint cannot deal with 0 byte files.

yes, can confirm. If I upload .pptx with content -> I can open and collaboration mode works

@mmattel
Copy link
Contributor

mmattel commented Nov 7, 2024

@ScharfViktor The admin docs upgrade/migration guide PR is final and ready to merge, you can have a look to the rendered version at docs staging. Here you can see beside necessary content changes als info about CLI changes and envvar changes.

@micbar
Copy link
Contributor

micbar commented Nov 8, 2024

🎉 Release Candidate v7.0.0-rc.1

Changelog

oCIS

  • Bugfix - Removed 'OCM_OCM_PROVIDER_AUTHORIZER_VERIFY_REQUEST_HOSTNAME' setting: #104
  • Bugfix - Respect proxy url when validating proofkeys: #1234
  • Bugfix - Generate short tokens to be used as access tokens for WOPI: #10391
  • Bugfix - Fix put relative wopi operation for microsoft: #10403
  • Bugfix - Make SSE keepalive interval configurable: #10411
  • Bugfix - Micro registry cache fixes: #10429
  • Bugfix - Fix the memlimit loglevel: #10431
  • Bugfix - Restart Postprocessing properly: #10439
  • Bugfix - Allow to configure data server URL for ocm: #10440
  • Bugfix - Return wopi lock header in get lock response: #10469
  • Bugfix - 'ocis backup consistency' fixed for file revisions: #10493
  • Bugfix - Wait for services to be ready before registering them: #10498
  • Bugfix - Fix 0-byte file uploads: #10500
  • Bugfix - Fixed sharedWithMe response for OCM shares: #10501
  • Bugfix - Fix gateway nats checks: #10502
  • Enhancement - Create thumbnails for GGP MIME types: #10303
  • Enhancement - Include a product name in the collaboration service: #10335
  • Enhancement - Add web extensions to the ocis_full example: #10399
  • Enhancement - Remove deprecated CLI commands: #10430
  • Enhancement - Bump cs3api: #10448
  • Enhancement - Bump reva to latest: #10472
  • Enhancement - Concurrent userlog processing: #10504
  • Enhancement - Concurrent autoaccept for shares: #10505

Web

Reva

@jesmrec
Copy link

jesmrec commented Nov 11, 2024

Mobile

Server version:

Infinite Scale 6.6.1 Community 
Infinite Scale v7.0.0-rc.1 (smoking)

Android

Device & Android version: Xiaomi Redmi 13, Android 14

Android app version: v4.4.1

Test Case Steps Expected Result Result Related Comment
Login OIDC Login in an oCIS server, typing correct OIDC credentials Access to account Passed
New folder Open FAB and select to create a new folder with correct name The folder is created with the correct name Passed AUTO
Rename 1. Long press on a folder
Select Rename and type new name		 Folder is renamed with the new name Passed AUTO
Move 1. Long press on a folder
2. Select Move, and a new location		 Folder is moved to the specified location Passed AUTO
Copy 1. Long press on a folder
2. Select Copy, and a location to copy to (including space)		 The folder and all its content is copied in the location, and also remains in the original Passed AUTO
Delete 1. Long press on a folder
2. Select Delete		 Item deleted Passed AUTO
Sync 1. Create a folder
2. In web app, upload some files in the folder
3. Long press to sync the folder		 The folder is sync with the content on server Passed AUTO
Upload Select 300 files from Document provider to upload to oC Files are uploaded and visible in the list of files. All OK in uploads view Passed
Upload from 3rd party app Select 300 files from an external app like Photos and share them with oC Files are uploaded and visible in the list of files. All OK in uploads view Passed
Download Tap to download a file The file is downloaded and marked with green arrow Passed AUTO
Preview Tap to download a image, a txt, a video and an audio files Files are downloaded and previewed correctly Passed AUTO
Open with 1. Long press on a txt file
2. Select Open with
3. Edit the file with an external editor and save it
4. Reopen oC		 File is synced back to the server including the changes Passed
Av Offline file 1. Long press on a file
2. Select Av. offline		 The file is downloaded and set as Av Offline with the purple tick Passed AUTO
Av Offline folder 1. Long press on a folder with subfolders and files inside
2. Select Av. offline
3. Add new content to the folder		 2. The folder and all its content is downloaded and set as Av Offline with the purple tick
3. New content is available offline		 Passed AUTO
Share with user 1. Share a file and a folder with another user
2. In web, accept the shares		 Both are correctly shared and visible by the recipient in Shares space Passed AUTO
Link Create a link over a file and a folder Links are correctly created Passed AUTO
Spaces In web, create some spaces that are visible for the user List of spaces is visible in the app Passed AUTO
Open with web Open any file with an external app provider File opened in browser with the proper app provider Passed Tested with all Collabora supported formats
Edit with web Open any file with an external app provider, edit the file, and save it File synced with changes Passed Tested with all Collabora supported formats
Document Provider 1. Add several accounts
2. Open any app with SAF support		 All accounts are correctly listed and are browsable Passed

E2E Report: https://reports.cucumber.io/reports/6f67dd52-adc9-4c29-8ecc-5258ad66839e

iOS

Device & iOS version: iPhone XR, iOS 18.1

iOS app version: v12.3.1

Test Case Steps Expected Result Result Related Comment
Login OIDC Login in an oCIS server, typing correct OIDC credentials Access to account Passed
New folder Select to create a new folder The folder is created with the correct name Passed AUTO
Rename Rename an existing folder Folder is renamed with the new name Passed AUTO
Move 1. Open the card of a folder
2. Select Move, and a new location		 Folder is moved to the specifield location Passed AUTO
Copy 1. Open the card of a folder
2. Select Copy, and a location to copy to		 The folder and all its content is copied in the location, and remains too in the original Passed AUTO
Duplicate 1. Open the card of a folder
2. Select Copy, and a location to copy to		 The folder and all its content is copied in the location, and remains too in the original Passed AUTO
Delete 1. Open the card of a folder
2. Select Delete		 Item deleted Passed AUTO
Upload Files Select several files from Document provider to upload to oC Files are uploaded Passed
Upload Albums Select several images and videos from Albums to upload to oC Images and videos are uploaded Passed AUTO
Upload from 3rd party app Select 300 files from an external app like Gallery and share them with oC Files are uploaded and visible in the list of files. All OK in uploads view Passed
Download Tap to download a file The file is downloaded and marked with green arrow Passed AUTO
Preview Tap to download a image, a txt, a video and an audio files Files are downloaded and previewed correctly Passed AUTO
Av Offline Open the card of a file to set as Av Offline The file is downloaded and set as Av Offline Passed AUTO
Av Offline folder Open the card of a folder to unset as Av Offline The folder and all its content is downloaded and set as Av Offline Passed AUTO
Share with user Share a file and a folder with another user Both are correctly shared Passed AUTO
Link Create a link over a file and a folder Links are correctly created Passed AUTO
Open with web Open any file with an external app provider File opened in browser with the proper app provider Passed Tested with all Collabora supported formats
Edit with web Open any file with an external app provider, edit the file, and save it File synced with changes Passed Tested with all Collabora supported formats
Files Provider 1. Add several accounts
2. Open any app with FP support		 All accounts are correctly listed and are browsable Passed

E2E Report: https://reports.cucumber.io/reports/02bdc1e2-c52f-479d-8993-005a3e020f5d

Changelog items

Mobile apps don't support OCM and activity features yet. So, skipping those items.
Android does not support TUS. Uploads in iOS tested as part of the testing

Removed resharing: https://github.com/owncloud/ocis/pull/8762

Android: Passed

iOS: Passed

Hidden shares: https://github.com/owncloud/ocis/issues/7383

Android: not working, hidden share is always shown. Need check in client side

iOS: Passed

Regards

  • Creating a new document in collaboration, i found cases like
        {
            "allow_creation": true,
            "app_providers": [
                {
                    "address": "com.owncloud.api.collaboration.CollaboraOnline",
                    "description": "Open office documents with Collabora",
                    "icon": "https://collabora.ocis.rolling.owncloud.works/favicon.ico",
                    "name": "CollaboraOnline",
                    "secure_view": false
                }
            ],
            "default_application": "OnlyOffice",
            "description": "Microsoft PowerPoint document",
            "ext": "pptx",
            "mime_type": "application/vnd.openxmlformats-officedocument.presentationml.presentation",
            "name": "Microsoft PowerPoint"
        }

in which the default_application was not one of the providers, causing an error in creation time. This is only stethyc because the file is created and can be edited. As commented with Viktor via chat, it could be fixed with an env variable.

Related: #10276

Secure View is not implemented in mobile clients yet, and not tested since there was no available environment to test it. After some attempts to create a backend, it didn't work.

Conclusion

Ok from mobile side

@ScharfViktor
Copy link
Contributor Author

during the testing https://doc.staging.owncloud.com/ocis/next/migration/upgrading_5.0.x_7.0.0.html I found that patch command is missing in the ocis image
owncloud/docs-ocis#1029 (comment)

@ScharfViktor ScharfViktor mentioned this issue Nov 11, 2024
Merged
@micbar
Copy link
Contributor

micbar commented Nov 12, 2024 •
edited
Loading

🎉 Release Candidate 7.0.0-rc.2

Known Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 7.0.0
Development

No branches or pull requests
7 participants
@mmattel @micbar @jesmrec @JammingBen @saw-jan @ScharfViktor @nirajacharya2