test_serving.py hangs

[0-wiz-0]

I've been updating the werkzeug package for pkgsrc.
Starting with 3.1.0 (still there in 3.1.3) I see a test hang in test_serving.py.
If I remove the file, most other tests pass except for

___________________________________________________________________________________________________ test_get_machine_id ____________________________________________________________________________________________________

    def test_get_machine_id():
        rv = get_machine_id()
>       assert isinstance(rv, bytes)
E       assert False
E        +  where False = isinstance(None, bytes)

tests/test_debug.py:245: AssertionError
================================================================================================= short test summary info ==================================================================================================
FAILED tests/test_debug.py::test_get_machine_id - assert False

I'm using the pypi source distfile, and run the tests after building and installing werkzeug by running pytest in the build directory.
The output looks like this:

tests/middleware/test_dispatcher.py .                                                                                                                                                                                [  0%]
tests/middleware/test_http_proxy.py .                                                                                                                                                                                [  0%]
tests/middleware/test_lint.py .........                                                                                                                                                                              [  1%]
tests/middleware/test_profiler.py .                                                                                                                                                                                  [  1%]
tests/middleware/test_proxy_fix.py .................                                                                                                                                                                 [  3%]
tests/middleware/test_shared_data.py ..                                                                                                                                                                              [  3%]
tests/sansio/test_multipart.py .....................                                                                                                                                                                 [  5%]
tests/sansio/test_request.py .........                                                                                                                                                                               [  6%]
tests/sansio/test_utils.py ........................                                                                                                                                                                  [  8%]
tests/test_datastructures.py ...........................................................................................................................                                                             [ 21%]
tests/test_debug.py ...............F.....                                                                                                                                                                            [ 24%]
tests/test_exceptions.py ............................................................................................                                                                                                [ 33%]
tests/test_formparser.py ...........................                                                                                                                                                                 [ 36%]
tests/test_http.py ........................................................................................................................                                                                          [ 49%]
tests/test_internal.py .                                                                                                                                                                                             [ 49%]
tests/test_local.py ...............................................................                                                                                                                                  [ 56%]
tests/test_routing.py .....................................................................................................................                                                                          [ 68%]
tests/test_security.py ............                                                                                                                                                                                  [ 69%]
tests/test_send_file.py ................................                                                                                                                                                             [ 73%]
tests/test_serving.py .

and then nothing happens.

Can you please advise how to debug/fix this? Thanks.

Environment:

• Python version: 3.13.0
• Werkzeug version: 3.1.0 up to 3.1.3

[davidism]

It sounds like you're running the tests in a custom way. The server tests are likely sensitive to the current directory and sys.path, so if things are out of place they may not start correctly. Note that they also start servers listening on random high ports bound to the local interface, so that needs to be available in your environment. I ran the build and tests from sdist for version 3.1.3 in the following way:

# get the 3.1.3 sdist from pypi
$ curl -O https://files.pythonhosted.org/packages/9f/69/83029f1f6300c5fb2471d621ab06f6ec6b3324685a2ce0f9777fd4a8b71e/werkzeug-3.1.3.tar.gz
$ tar xf werkzeug-3.1.3.tar.gz
$ cd werkzeug-3.1.3

# create a virtualenv
$ python3.13 -m venv .venv
$ . .venv/bin/activate

# install the build and test requirements
$ pip install -r requirements/build.txt -r requirements/tests.txt

# build and install the wheel
$ python -m build
$ pip install dist/werkzeug-3.1.3-py3-none-any.whl

# run pytest
$ pytest

All tests pass successfully.

[0-wiz-0]

Thanks for looking at this. Digging deeper again in the differences between a setup produced by what you write and what we had in pkgsrc is that pkgsrc didn't install cryptography. When I install that, the tests succeed (except for the one).

[0-wiz-0]

Hm, sorry, I had forgotten I had completely disabled the test locally. With cryptography (and all the other requirements) installed, I see the same but after more dots:

tests/test_serving.py ..........

pytest -v says this is

tests/test_serving.py::test_reloader_sys_path[watchdog]

[0-wiz-0]

Perhaps it's an issue with the exact versions of the dependencies. In pkgsrc, we usually package the newest version, and we install that version for testing. So the installed versions are:

build-1.2.2.post1
cffi-1.17.1
cryptography-43.0.3
ephemeral_port_reserve-1.1.4
flit_core-3.10.1
iniconfig-2.0.0
installer-0.7.0
markupsafe-3.0.2
packaging-24.2
pluggy-1.5.0
psutil-6.1.0
pycparser-2.22
pyparsing-3.2.0
pyproject_hooks-1.2.0
pytest-8.3.3
pytest-timeout-2.3.1
pytest-xprocess-1.0.2
watchdog-6.0.0
yaml-6.0.2

but the autogenerated file you used has hardcoded e.g. packaging 24.1 and watchdog 5.0.3.