Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GB -vs -UK #15

Open
clancger opened this issue Apr 25, 2017 · 4 comments
Open

GB -vs -UK #15

clancger opened this issue Apr 25, 2017 · 4 comments
Assignees
Milestone

Comments

@clancger
Copy link

I just noticed that the only search term that will show all United Kingdom entries is "GB".
Could you please implement that "UK", "United Kingdom", "Great Britain" are treated as synonyms for "GB"?

pd gb listing 25 04 17

@phax
Copy link
Owner

phax commented Apr 25, 2017

This is heavyweight... synonyms - already :)
Okay - I see whether I can do country code synonyms.
Question 1: only if "UK" is searched standalone or also when it is searched like in "UK hospital"?
Question 2: What language to synonym it to? Just in English? Or to all languages the country is assigned to?

@phax phax self-assigned this Apr 25, 2017
@clancger
Copy link
Author

  1. I think only "UK" standlone, I'm not sure if combined search terms would be
  2. In time localisation may be necessary, but for the time being just English

I could also imagine that eg someone in elsewhere in Europe could be searching for an address in UK with the search term as England, even if the actual location was in eg Wales. Not trying to solve all the possible potential issues, but just trying to capture cases that will be likely to arise commonly

@phax phax modified the milestones: 1.0, 1.1 Apr 27, 2017
@stale
Copy link

stale bot commented May 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 14, 2019
@phax phax removed the wontfix label May 15, 2019
@stale
Copy link

stale bot commented Aug 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 13, 2019
@phax phax added pinned and removed wontfix labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants