Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to currentAd during AdMode. #50

Open
bryanrite opened this issue Oct 10, 2024 · 2 comments
Open

Access to currentAd during AdMode. #50

bryanrite opened this issue Oct 10, 2024 · 2 comments

Comments

@bryanrite
Copy link

bryanrite commented Oct 10, 2024

It doesn't appear that during AdMode the currentAd is accessible via the vast or ad classes. Can we make currentAd accessible via player.vast().currentAd() or something along those lines?

Ultimately I'm attempting to check for skipOffset from the <Linear> VAST tag to set the skip timer dynamically and just trigger a skip event from a custom element external to the video player.

@philipwatson
Copy link
Owner

Hi @bryanrite , sorry for very late reply. 3 weeks 😅
I'm not sure if I want to expose currentAd. It's an implementation detail that I might change later.
I want to support the skipOffset.. so created this PR: #52
Does this work for you? or do you still need something custom?

@bryanrite
Copy link
Author

@philipwatson I'll see your 3 weeks and match 😄

Sorry, missed this as well, that works very well, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants