Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image in lectures/flow/switch #23

Open
jweeks2023 opened this issue Jun 11, 2024 · 4 comments
Open

Broken image in lectures/flow/switch #23

jweeks2023 opened this issue Jun 11, 2024 · 4 comments
Labels
formatting Formatting issue that causes irregular display on website

Comments

@jweeks2023
Copy link
Collaborator

!["A flowchart representation of the mapping between month number and name"](img/activity_diag_month)

@jweeks2023 jweeks2023 added the formatting Formatting issue that causes irregular display on website label Jun 11, 2024
@aubertc
Copy link
Contributor

aubertc commented Jun 11, 2024

ddd2cd0 will solve that.

@jweeks2023
Copy link
Collaborator Author

It is fixed, however, it seems this image is not accessible for dark mode users. See picture below:

image

@jweeks2023
Copy link
Collaborator Author

This is actually a widespread issue with these diagrams, which I believe are related to the fact that you are using SVGs for these. There are multiple ways to approach this (i.e., add backgrounds to them, modify the color scheme to have light and dark variants, etc.), but each solution has its pros and cons, so I will leave that to you to decide how to proceed.

@aubertc
Copy link
Contributor

aubertc commented Jun 27, 2024

Ok, I'll try to think of a global solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatting Formatting issue that causes irregular display on website
Projects
None yet
Development

No branches or pull requests

2 participants