Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand coverage for pip install test #348

Open
gerrod3 opened this issue Mar 15, 2021 · 0 comments
Open

Expand coverage for pip install test #348

gerrod3 opened this issue Mar 15, 2021 · 0 comments
Labels
Tests Improvements or additions to testing

Comments

@gerrod3
Copy link
Contributor

gerrod3 commented Mar 15, 2021

Original Pulp Redmine Issue: https://pulp.plan.io/issues/6838

The pip install test uses only the sdist (.tar.gz) package type when checking that it can install 'shelf-reader'. However, the repository has an additional wheel (.whl) version that could be installed from but isn't checked.

Currently the default behavior for pip install (Verision 20.1.1 on Python 3.7) seems to use the sdist type if the package 'wheel' is not installed (see pip install message below). Checking the pip forums the discussion on the workings of pip install seem to be ongoing and could be subject to change.

When documentation is available for the workings of pip install the pip install test should be expanded to test installing from different package types.

$ pip install --trusted-host localhost -i http://localhost:24816/pulp/content/4352fcae-4ca3-4df1-ab0f-199adc3cec8c/simple/ shelf-reader
Looking in indexes: http://localhost:24816/pulp/content/4352fcae-4ca3-4df1-ab0f-199adc3cec8c/simple/
Collecting shelf-reader
  Downloading http://localhost:24816/pulp/content/4352fcae-4ca3-4df1-ab0f-199adc3cec8c/shelf-reader-0.1.tar.gz (19 kB)
Using legacy setup.py install for shelf-reader, since package 'wheel' is not installed.
Installing collected packages: shelf-reader
    Running setup.py install for shelf-reader: started
    Running setup.py install for shelf-reader: finished with status 'done'
Successfully installed shelf-reader-0.1
@gerrod3 gerrod3 added the Tests Improvements or additions to testing label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Improvements or additions to testing
Projects
None yet
Development

No branches or pull requests

1 participant