-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations to code examples in "Getting Started" #318
Comments
I'm leaning towards doing this but I'm not completely certain. |
Leaning against this because:
|
The types will be encountered anyway - if they're not present in the examples, then the warning suggests adding them and writes them out for you:
|
I agree with @hdgarrood on this. But I also agree w/ @milesfrain. There are good arguments on both sides. For that reason, I don't feel it's worthwhile pursuing this any longer; it has lingered long enough. Hence agree with the earlier closing. |
People will probably not expect the code examples they encounter in the Getting Started guide to emit warnings, but right now, they do, because they do not include type annotations. It may be worth changing the guide to include type annotations, because beginners might think that warnings indicate a problem. See also the discussion in #305.
The text was updated successfully, but these errors were encountered: