Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasi + Emscripten: configure behavior with --enable-optimizations seems incorrect? #126748

Open
hoodmane opened this issue Nov 12, 2024 · 1 comment
Labels
build The build process and cross-build OS-emscripten OS-wasi

Comments

@hoodmane
Copy link
Contributor

hoodmane commented Nov 12, 2024

configure.ac sets DEF_MAKE_ALL_RULE to:

  • if --enable-optimizations is passed, then profile-opt
  • if ac_sys_system is Emscripten or WASI then build_wasm
  • if neither of these, then build_all.

build_wasm is a modified version of the build_all target that drops some targets that don't build correctly in webassembly targets or are unneeded. This logic hasn't been added for the case when --enable-optimizations is passed. I think the best solution for now would be to check for these targets with --enable-optimizations and error out. I don't think PGO will work on the wasm targets without tinkering either way.

Linked PRs

@brettcannon
Copy link
Member

I agree that erroring out if WASI or Emscripten is selected is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build OS-emscripten OS-wasi
Projects
None yet
Development

No branches or pull requests

2 participants