Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apps:// pseudo-protocol? #25

Open
cboulanger opened this issue Feb 13, 2021 · 2 comments
Open

Remove apps:// pseudo-protocol? #25

cboulanger opened this issue Feb 13, 2021 · 2 comments

Comments

@cboulanger
Copy link
Contributor

cboulanger commented Feb 13, 2021

There were two ideas behind introducing the apps:// pseudo-protocol to indicate links to the qooxdoo apps:

  • it made it possible to have local versions of the qooxdoo apps that could be linked to in the documentation. Docsify would dynamically reference the online or offline version dependent on whether it was run with qx serve or from the qooxdoo domain. However, we no longer ship the offline apps with the NPM release-
  • it would speed up linting as the links were considered to be safe. However, the links can be faulty if the apps change something in their approach to routing (which would be bad, because non-BC) or if there is something broken. The question is if the increase in speed is more valuable than alerting us to broken links.

I suggest we replace apps:// with real https:// links. This would also make them work when viewing the docs on GitHub. It would still be possible to implement some kind of dynamic redirection if we need it, based on those links.

@derrell
Copy link
Member

derrell commented Feb 13, 2021

+1

1 similar comment
@hkollmann
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants