From 69ce513bdccc002a7fc4920ab6b7b373c593d2ff Mon Sep 17 00:00:00 2001 From: Ceki Gulcu Date: Tue, 5 Nov 2024 15:28:29 +0100 Subject: [PATCH] minor rewording Signed-off-by: Ceki Gulcu --- .../src/main/java/ch/qos/logback/core/ConsoleAppender.java | 5 ++++- .../src/main/java/ch/qos/logback/core/CoreConstants.java | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/logback-core/src/main/java/ch/qos/logback/core/ConsoleAppender.java b/logback-core/src/main/java/ch/qos/logback/core/ConsoleAppender.java index 1bd0cd9426..6929a466aa 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/ConsoleAppender.java +++ b/logback-core/src/main/java/ch/qos/logback/core/ConsoleAppender.java @@ -53,6 +53,8 @@ public class ConsoleAppender extends OutputStreamAppender { private final static String wrapSystemErr_METHOD_NAME = "wrapSystemErr"; private final static Class[] ARGUMENT_TYPES = { PrintStream.class }; + private final static String CONSOLE_APPENDER_WARNING_URL = CoreConstants.CODES_URL+"#slowConsole"; + /** * Sets the value of the Target option. Recognized values are * "System.out" and "System.err". Any other value will be ignored. @@ -86,7 +88,8 @@ private void targetWarn(String val) { @Override public void start() { addInfo("BEWARE: Writing to the console can be very slow. Avoid logging to the "); - addInfo("console in production, especially in high volume systems."); + addInfo("console in production environments, especially in high volume systems."); + addInfo("See also "+CONSOLE_APPENDER_WARNING_URL); OutputStream targetStream = target.getStream(); // enable jansi only if withJansi set to true if (withJansi) { diff --git a/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java b/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java index 593328c35c..e259cafea1 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java +++ b/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java @@ -44,8 +44,8 @@ public class CoreConstants { public static final String LINE_SEPARATOR = System.getProperty("line.separator"); public static final int LINE_SEPARATOR_LEN = LINE_SEPARATOR.length(); - public static final String CODES_URL = "http://logback.qos.ch/codes.html"; - public static final String MANUAL_URL_PREFIX = "http://logback.qos.ch/manual/"; + public static final String CODES_URL = "https://logback.qos.ch/codes.html"; + public static final String MANUAL_URL_PREFIX = "https://logback.qos.ch/manual/"; public static final String MORE_INFO_PREFIX = "For more information, please visit "; /**