-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages with unusual number of requests #1660
Comments
It isn't exactly a page with an unusual number of requests, but I managed to isolate a feature producing what strikes me as more requests than necessary; see #1662. |
The Won page:
I don't see how it's necessary to look through the whole list of winners (or any at all for that matter) of a giveaway when I'm on the won page and it's clear that I was one of them (hence the giveaway being on the Won page in the first place). |
Looks like the feature fetches winners when on the created and won pages. There must have been a reason why I made it run in the won page, but I honestly don't remember, and I can't think of any valid reason right now. I should really start commenting the code more... I'll fix it in the next version. |
On the created page it might be for the mouse over on winners to get them listed in the pop up. Though that list always was only loaded when actually hovering over it - at least I always got a loading animation and had two wait a bit to get it shown. (Talking from memory - but pretty sure that feature exists on the created page. I don't think it does on the won page). But I haven't made use of that for a while so it might be a somewhat recent change that caused that behavior. |
On the all page:
I can't see a reason why "wishlist" would be requested while loading the second page of All with endless scrolling. |
Just checked and under "Last Hour" I found this:
No idea what all these "/account/manage/whitelist/", "/account/manage/blacklist/" and especially the "/account/settings/giveaways/filters/" request are about. Could it be from automatic syncing? I certainly didn't start sync manually. What even is the giveaways/filters request looking up? Also, I do not have 17 pages of black list entries. I think for syncing data there should be a "last known" giveaway data point (giveaway name, date, time) stored locally. And syncing new data should stop once that point is reached be to avoid going through all the games of whatever e.g. giveaways/filters is. |
How many pages of blacklist do you have? The feature is configured to stop once it reaches the last page, so I don't know how it could be getting that wrong. For syncing giveaways, there already is a last known point. When syncing hidden games, it has to go through all pages because there's no way of knowing what changes have been made otherwise. But like I said, you can just enable the options in the settings menu to automatically update those lists and you never have to sync them again (unless you want to double check that everything is synced). |
Also, requests to |
And you might want to be careful posting giveaway logs, in case there are private giveaways among them. Probably safer to redact those. |
Ok. I've activated these automatic updates. |
I'm getting this on the Wishlist page:
Even if I just loaded the page. |
There's a chance that you auto synced right before causing the issue. |
Can I turn that off somehow? It happens pretty much every day. |
Thanks! Strange, all of them were set to 30 days, not sure why I got that too many requests error almost every day. (And it says they were last synced 2 months ago.) |
Report any pages with unusual number of requests, as reported by the SteamGifts Request Log, here.
The text was updated successfully, but these errors were encountered: