-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Gitjob Controller into Fleet Controller / Chart #2008
Comments
manno
changed the title
Move Gitjob Controller into Fleet Repo
Merge Gitjob Controller into Fleet Controller / Chart
Dec 20, 2023
This was referenced Jan 23, 2024
Once #2098 is merged:
|
When next releasing Fleet from a branch including #2098:
|
This was referenced Jan 30, 2024
This was referenced Feb 7, 2024
Merged
This was referenced Feb 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rancher/gitjob is only used by Fleet, and adds to its maintenance/release overhead, both for Go code and for charts.
Instead, we could integrate
rancher/gitjob
contents intorancher/fleet
and manage all Fleet-related logic from there.Note:
Merging gitjob into the same code base adds some interesting possibilities in the future. We might be able to remove the gitjob CRD, the gitjob container image, so we have less complexity and a smaller download size.
This will become clearer when be build OCI repo support, but gitjob/gitrepo are as much their own component as oci repo is. So the split between gitjob vs gitrepo doesn’t make sense. Eventually, we might have “bundle” producing components (gitrepo, ocirepo) and a component which distributes bundles to clusters (fleetcontroller/targetting).
So, in short, we’re moving gitjob now, so maintenance and releases get easier, but it will also enable a clearer design in the future.
This would require us to:
gitjob
helm chart, placing it in thefleet
chart (no more sub chart)internal/cmd/gitjob
)GitJob
resource in the future and use GitRepo instead?More housekeeping (in no particular order)
.gitignore
rancher/gitjob
in docs throughoutrancher/fleet
.github/scripts/check-for-gitjob-changes.sh
The text was updated successfully, but these errors were encountered: