Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure Splitting Packets #3716

Open
evhub opened this issue Jul 20, 2024 · 2 comments
Open

Failure Splitting Packets #3716

evhub opened this issue Jul 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@evhub
Copy link

evhub commented Jul 20, 2024

Describe the bug

I'm seeing a reappearance of #3466 even with the larger packet limit of 10. Would it be possible to increase the packet limit further?

How can we reproduce this bug or crash?

  1. Fill a storage system with items using a lot of data.
  2. Open a grid to view the items.
  3. Not all the items are visible.

What Minecraft version is this happening on?

Minecraft 1.20.1

What Forge version is this happening on?

47.3.0

What Refined Storage version is this happening on?

1.12.4

Relevant log output

[15:23:31] [Server thread/ERROR] [co.re.re.ne.PacketSplitter/]: Failure Splitting Packets on Channel "refinedstorage:main_channel". with class com.refinedmods.refinedstorage.network.grid.GridItemUpdateMessage.  Number of Packets sent 10, expected number of Packets 12, maximum number of packets for a message of this type 10
@evhub evhub added the bug Something isn't working label Jul 20, 2024
@evhub
Copy link
Author

evhub commented Jul 20, 2024

I'd also love a pointer to where in the code you set the packet limit so I can experiment with increasing it myself.

@Darkere
Copy link
Collaborator

Darkere commented Jul 21, 2024

private final PacketSplitter splitter = new PacketSplitter(10, handler, channel);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants