Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid menu doesn't handle network changes #366

Closed
raoulvdberge opened this issue Apr 4, 2023 · 2 comments · Fixed by #372 or #467
Closed

Grid menu doesn't handle network changes #366

raoulvdberge opened this issue Apr 4, 2023 · 2 comments · Fixed by #372 or #467
Assignees
Labels
bug Something isn't working

Comments

@raoulvdberge
Copy link
Contributor

raoulvdberge commented Apr 4, 2023

Describe the bug

Watcher listeners become out of date + strategies too.

How can we reproduce this bug or crash?

  1. Place a grid
  2. Place a cable
  3. Place other blocks after the cable
  4. Put a destructor destroying the cable from step 2
  5. Open the grid quickly, before destructor from step 4 destroys cable from step 2
  6. Network is split, see what happens.

What Minecraft version is this happening on?

Minecraft 1.19.3

What Forge or Fabric version is this happening on?

latest

What Refined Storage version is this happening on?

latest

Relevant log output

No response

@raoulvdberge raoulvdberge added the bug Something isn't working label Apr 4, 2023
@raoulvdberge raoulvdberge added this to the v2.0.0-milestone.2 milestone Apr 4, 2023
@raoulvdberge raoulvdberge self-assigned this Apr 4, 2023
@raoulvdberge raoulvdberge moved this from Todo to In Progress in Refined Storage 2 Apr 4, 2023
@raoulvdberge raoulvdberge moved this from In Progress to Todo in Refined Storage 2 Apr 4, 2023
@raoulvdberge raoulvdberge moved this from Todo to In Progress in Refined Storage 2 Apr 16, 2023
raoulvdberge added a commit that referenced this issue May 27, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Refined Storage 2 May 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2023
@raoulvdberge raoulvdberge reopened this Jan 1, 2024
@raoulvdberge raoulvdberge moved this from Done to Todo in Refined Storage 2 Jan 1, 2024
@raoulvdberge
Copy link
Contributor Author

raoulvdberge commented Jan 1, 2024

This issue was fixed for splits, but merges suffer from the same issue. The fix doesn't handle that.

  • Place 2 sets of networks w/ grid, controller and storage (player facing north).
  • Add a constructor with cable that will merge them.
  • Left side will get a new network, so the grid view will get cleared on the left.
  • However, only the storages from the left side will be re-synced as that is the only new storage that was added. Storage from the right already existed so that won't get re-added.

@raoulvdberge raoulvdberge moved this from Todo to In Progress in Refined Storage 2 Jan 1, 2024
@raoulvdberge
Copy link
Contributor Author

Fixed in #467

@github-project-automation github-project-automation bot moved this from In Progress to Done in Refined Storage 2 Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.