Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can maintain #63

Open
gbougakov opened this issue Feb 28, 2017 · 6 comments
Open

I can maintain #63

gbougakov opened this issue Feb 28, 2017 · 6 comments

Comments

@gbougakov
Copy link
Contributor

NPM username: georgenet
I understand everything inside the code.

@gbougakov
Copy link
Contributor Author

I found a bug and I know how to fix it. (In the npm version)

@NovaGL
Copy link
Collaborator

NovaGL commented Mar 4, 2017

Is the bug in the github version too? Not sure If I can add you to the npm version.

If you have anything feel free to do a pull request.

@gbougakov
Copy link
Contributor Author

gbougakov commented Mar 6, 2017

@NovaGL Actually code in npm and github is different, but none of them are stable and homebridge crashes when it reaches here.

Problem

Line 46 says done(error);
That throws an uncaught "critical" network error, as a result - homebridge crashes.

Solution

Replace done(error); with this

@gbougakov
Copy link
Contributor Author

Actually IDK is it only on my server so unstable, so I had to rewrite all the plugin to make it stable?

@gbougakov
Copy link
Contributor Author

@NovaGL And yep, the npm version instead of done(error); says callback(error);

This was referenced Mar 6, 2017
@NovaGL
Copy link
Collaborator

NovaGL commented Mar 7, 2017

I don't think I can add you as I am not the owner, but I can merge your requests.

NovaGL added a commit that referenced this issue Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants