Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update breadcrumbs design to be full width and sit underneath navbar #37

Open
robbieaverill opened this issue Apr 3, 2019 · 3 comments

Comments

@robbieaverill
Copy link
Contributor

robbieaverill commented Apr 3, 2019

Existing breadcrumbs example:

image

New designs:

image

Invision designs:
https://invis.io/AWO7CJSK426#/331465174_Wa-tea_Plus_Landing_Page

cc @silverstripeux

@robbieaverill
Copy link
Contributor Author

We may want to make this change in the starter theme instead. cc @silverstripe/designers

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Apr 3, 2019

Random note: Currently $Breadcrumbs is expected in Layout/Page.ss. This might make it a little hard to implement these designs?

@clarkepaul
Copy link
Contributor

So the Starter theme is supposed to be less opinionated with design and uses as much of the Bootstrap defaults s we don't add unnecessary bloat to it. I guess this means every template is going to need to overriden for this change in Wātea? I think that's the approach we should take even though its more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants