Regression: Allow help links to be disabled in user code

[nathanbrauer]

As requested in silverstripe/silverstripe-cms#1020, #156 added the ability to disable the help_link.

In the upgrade from help_link to help_links, #615 seems to have inadvertently removed this.

The following are expected to work, but now result in [Warning] foreach() argument must be of type array|object, bool given:

SilverStripe\Admin\LeftAndMain:
  help_links: false

SilverStripe\Admin\LeftAndMain:
  help_links: null

For good measure, I did try the following and it is not effective:

SilverStripe\Admin\LeftAndMain:
  help_links: []

PRs

• ENH Allow disabling of help_links #1572

[GuySartorelli]

PR merged