Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid_count block other tests execution #1924

Open
ViktorDronov opened this issue Aug 8, 2023 · 2 comments
Open

invalid_count block other tests execution #1924

ViktorDronov opened this issue Aug 8, 2023 · 2 comments

Comments

@ViktorDronov
Copy link

Steps to reproduce:
Table contain column 'strColumn' which type is 'string'

test.yml:

checks testTable:
    - row_count:
        warn: when = 0
        name: Table cannot be empty
    - schema:
         fail:
            when required column missing:
               - strColumn
    - missing_count(strColumn) = 0:
          name: strColumn should be provided
    - invalid_count(strColumn) = 0:
          name: strColumn must be a positive number # << Not true because strColumn is string
          valid min: 1                                                      # << Invalid pattern because string cannot be greater then 1

Expected results:
At least 3 results should be returned for row_count, schema and missing_count. Error from the invalid_count should be captured by get_checks_fail_text()

Current results:
1 result received for schema, 3 results missed

Environment:
soda-core-spark-df==3.0.46
Databricks

@jmarien
Copy link
Contributor

jmarien commented Aug 8, 2023

SODA-1806

@ViktorDronov
Copy link
Author

@jmarien what this number mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants