Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the "There are no references to Ember.$, $ or jQuery" test case align with desired usage? #1634

Open
notmessenger opened this issue Mar 2, 2016 · 1 comment

Comments

@notmessenger
Copy link
Collaborator

unit/components/sl-grid-test.js

The occurrence of this test case differs from other uses of it across the codebase (except for unit/components/sl-modal-test.js, which should be different).

@SpikedKira
Copy link
Contributor

perhaps this test should simply test that the number of times called is equal to number of times this.namespaceEvent() is called, which would allow the test in all components to be identical, despite some actually making global calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants