Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Time and Wind #49

Open
plantiac opened this issue Oct 12, 2023 · 11 comments
Open

Incompatible with Time and Wind #49

plantiac opened this issue Oct 12, 2023 · 11 comments
Labels
bug Something isn't working compat Mod compatibility enhancement New feature or request / improvement of existing feature

Comments

@plantiac
Copy link

plantiac commented Oct 12, 2023

Versions

Minecraft 1.19.2
Fabric 0.14.22
Time and Wind 1.4.3
Realistic Sleep 1.8.3

Details

Realistic Sleep 'snaps' adjusted tick time back to vanilla tick time (if that makes sense).

Issue Report on Time and Wind: #24

@Steveplays28 Steveplays28 added bug Something isn't working compat Mod compatibility labels Oct 12, 2023
@Steveplays28
Copy link
Member

Hi, the most important features of Time and Wind, such as slowing time down are already implemented in Realistic Sleep. Use the tick delay option in the config.
Time and Wind is marked as breaks in the fabric.mod.json,, I'll add compatibility info to the readme.

@plantiac
Copy link
Author

Hey, I haven't got to configure realistic sleep yet and assumed the time manipulation only kicks in while sleeping. Thanks for the info

@plantiac
Copy link
Author

I know this doesn't fit in this issue but could you provide more information (in the README.md for other players as well) on what exactly gets sped up during sleep? Do crops also get sped up or only when the chunk tick speed multiplier is turned on?

@Steveplays28
Copy link
Member

Steveplays28 commented Oct 12, 2023

I can add some more documentation. As for your question, crops only get sped up when the chunk tick speed multiplier is turned on, but that causes heavy lag, especially in heavily modded packs. I might look into a better way to handle that for crops specifically.

@Steveplays28 Steveplays28 added the enhancement New feature or request / improvement of existing feature label Oct 13, 2023
@Steveplays28
Copy link
Member

Hi again plantiac, I'm curious as to how you got this to run at all, did you use a Fabric/Quilt loader override?
Time and Wind is marked as a conflict and shouldn't allow the game to load when ran together with Realistic Sleep.

@plantiac
Copy link
Author

Hey, I had both mods normally installed and there was no conflict pop-up hindering me from launching the game. I'm using your mod solely now, since includes taw funcionality and some other features as well.

@Steveplays28
Copy link
Member

Thanks for the quick response. I found out why: I added Time and Wind as a soft conflict instead of a hard breakage, I thought I added it as a hard breakage, my bad.

@MrGreenTea
Copy link

Hi, the most important features of Time and Wind, such as slowing time down are already implemented in Realistic Sleep. Use the tick delay option in the config. Time and Wind is marked as breaks in the fabric.mod.json,, I'll add compatibility info to the readme.

Is there some documentation on how to use tickDelay / what the value exactly means and does?

@Steveplays28
Copy link
Member

tickDelay allows you to delay the day/night cycle by a certain amount of ticks, every tick.
I might rework the settings in the future to be more clear.

@MrGreenTea
Copy link

Does this mean that a tickdelay of 1 means that the day and night are twice as long because every tick gets one extra tick? Does this allow fractional scaling of the day length? And does this mean day and night will both be longer?

@Steveplays28
Copy link
Member

Yes, with a tickDelay of 1 it'll mean the cycle is twice as long. Fractional scaling isn't implemented yet. Might rework all settings to allow fractions and options less than 1.
There's no individual settings for day and night yet, both are adjusted at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compat Mod compatibility enhancement New feature or request / improvement of existing feature
Projects
None yet
Development

No branches or pull requests

3 participants