Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Limit to compatible Django versions with setup.py's install_requires #134

Open
brki opened this issue Mar 2, 2017 · 0 comments
Open

Limit to compatible Django versions with setup.py's install_requires #134

brki opened this issue Mar 2, 2017 · 0 comments

Comments

@brki
Copy link
Contributor

brki commented Mar 2, 2017

As per https://packaging.python.org/requirements/#install-requires , CleanerVersion's setup.py should limit installation to known compatible Django versions.

If this has the consequence, though, of downloading a different Django version than the one that a user already has installed, it is not an optimal solution.

Two alternatives (which should perhaps be used together):

  • check early in setup.py to see if a non-compatible version of Django is already installed, and error out if that is the case (like in https://trac-hacks.org/ticket/9800#comment:4 ).
  • have a runtime check in the top level of versions/models.py, that raises an error if an incompatible version of Django is installed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant