Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow definition GridField has import/export CSV actions (that don't work) #354

Open
robbieaverill opened this issue Mar 27, 2018 · 4 comments

Comments

@robbieaverill
Copy link
Contributor

In SS4 the default GridField on the "Workflows" CMS area has an import and export CSV action:

image

The export action works, but the import action doesn't.

When compared with a SS3 version these actions are not available, so I suspect they shouldn't be there in SS4 either:

image

@robbieaverill
Copy link
Contributor Author

The GridField items should have their own export action, rather than the CSV for the whole GridField:

image

@robbieaverill
Copy link
Contributor Author

robbieaverill commented Mar 27, 2018

Ok, I've got the inline export buttons working. The import functionality has two problems:

  • We can't change "import CSV" at the moment, because it's not adjustable in core. We could extend the class instead.
  • The bulk loader for importing workflow definitions isn't actually being called after your submit the form
  • Re-open the import dialog to see MIME validation failed: Could not find a MIME type for extension yml - could be from the mimevalidator module

Note that the above three points are not regressions when testing between CWP 1.x and 2.x, whereas the broken export functionality is.

I'll submit a pull request to fix the first few issues which at least re-enables export functionality, and we can address import separately.

@robbieaverill
Copy link
Contributor Author

Worth mentioning - I think that this is probably caused by a compatibility issue with the mimevalidator module in CWP

@JamesDPC
Copy link

JamesDPC commented Dec 1, 2022

See also #418 related to import handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants