Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect - tests failures #15356

Open
mroz22 opened this issue Nov 12, 2024 · 1 comment
Open

connect - tests failures #15356

mroz22 opened this issue Nov 12, 2024 · 1 comment
Labels
connect Connect API related (ie. fee calculation)

Comments

@mroz22
Copy link
Contributor

mroz22 commented Nov 12, 2024

https://github.com/trezor/trezor-suite/actions/runs/11796762131/job/32859405391#step:16:3958

didn't we see errors like this in #15300 could it be flaky now?

cc @martykan
@mroz22 mroz22 added the connect Connect API related (ie. fee calculation) label Nov 12, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Nov 12, 2024
@martykan
Copy link
Member

Yes, seems like this is due to rejectPending
I would say it's a false negative, because we want to reject this promise, but if no one is listening to it, Jest picks it up as an unhandled rejection and fails.
I tried to fix it by adding finally which resets it to undefined but it seems like it doesn't always work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
connect Connect API related (ie. fee calculation)
Projects
Issues Suite
Status: 🎯 To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martykan @mroz22