New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Painfull callback if errors present #26

Open

groony opened this issue Jun 30, 2018 · 2 comments

Contributor

groony commented Jun 30, 2018 •

edited

Loading

performify/lib/performify/base.rb

Line 20 in dd84f06

fail!(with_callbacks: true) if errors?

In my opinion here must be false, because in my fail callback i can use variables that was not defined previously and it will raise exception.

Collaborator

kimrgrey commented Dec 11, 2018

Well, maybe. But it's a little bit breaking change 😞

Contributor Author

groony commented Jan 14, 2019 •

edited

Loading

@kimrgrey possible solution #30 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment