-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bootstrap v4.5 #89
Comments
I am *not* an expert but I really think that Bootstrap 4 is a bridge too far or not far enough and for sure not at all worth the pain of conversion.
If we are going to go through a major miserable upheaval - I would rather find a way to theme that does not include SASS. I would also like to see a web-components first approach as well. To me, SASS is a dead-end technology and BS4’s use of SASS makes it dead-end markup.
If we wanted to go through a major non-upwards compatible markup change - I would rather adopt something like PatternFly 4 that feels a little more future-proof than BS4 both on themeing and web components use.
Interestingly, there are some things I like better about PatternFly 3 - but it kind of was a project in transition and evolved as they figured out new best practices. I think PF4 is a nice rewrite that captures the best practices but it is not as “drop in” as PF4.
PF4 has its flaws - the team has lost its urge to have anything other than React as getting their love. You can make it work in HTML / CSS - which to me is the way forward for Tsugi but it means we will need to do some of our own paddling.
But I am such a CSS zero that I can’t even evaluate this correctly. But I am pretty confident that BS4 is a “no future” strategy and waste of time.
/Chuck
… On Jul 21, 2020, at 9:44 AM, David P. Bauer ***@***.***> wrote:
I'd like to upgrade Tsugi to use Bootstrap version 4.5.0. This version is a major rewrite from v3, so many aspects of Tsugi will need to be updated. https://getbootstrap.com/docs/4.5/migration/ <https://getbootstrap.com/docs/4.5/migration/>
I'm not sure the best way to avoid breaking Tsugi tools as they may rely on or assume that Bootstrap 3 is included and piggy-back off of the styling. Any suggestions are welcome.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#89>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJEJJT5Q2RHQ2NFOG4XOWTR4WLS3ANCNFSM4PDTTVPQ>.
|
Hi Chuck. Fair point! I definitely don't want to create a bunch of work that won't move the project forward in the long-term. However, I do feel that the limitations with Bootstrap 3 are beginning to make improvements a bit more difficult. I'd love to explore web-components and something like PatternFly, but I'm not sure what the roadmap for Tsugi would look like if we went that route. My day-to-day isn't as focused on this type of work anymore so I'll be the first to admit that I'm not as up-to-date with where the industry is headed ... or perhaps where it has already moved :) I'd love to do some work to spruce up the Tsugi UI a bit or to build components that could make creating high quality apps easier. So, let me know where you think my time could be best spent. |
On Jul 21, 2020, at 3:08 PM, David P. Bauer ***@***.***> wrote:
Hi Chuck. Fair point! I definitely don't want to create a bunch of work that won't move the project forward in the long-term. However, I do feel that the limitations with Bootstrap 3 are beginning to make improvements a bit more difficult.
I'd love to explore web-components and something like PatternFly, but I'm not sure what the roadmap for Tsugi would look like if we went that route. My day-to-day isn't as focused on this type of work anymore so I'll be the first to admit that I'm not as up-to-date with where the industry is headed ... or perhaps where it has already moved :)
I'd love to do some work to spruce up the Tsugi UI a bit or to build components that could make creating high quality apps easier. So, let me know where you think my time could be best spent.
I think there is a great way to do non-upwards compatible things and markup. We could introduce a variable in the Output class and set it to “BS3” or “PF4” and just generate very different markup in all the Output methods - that way BS3 tools can keep going without breaking and PF4 (or whatever) can emerge as they like.
The problem is that I am just no good at the JS/Browser/etc stuff that I just don’t even have the patience to see if PF4 could be made to work. It would take me weeks and be very frustrating and that would mean 15 Sakai LTI JIRAs would not get done.
So someone with some skills has to mock something up.
But something that would be really really cool would be to take this Sakai JIRA and validate the proposed ideas in Tsugi - and make that little static web site that lets you pick colors and see them adjust sample markup as a style guide.
https://jira.sakaiproject.org/browse/SAK-42272 <https://jira.sakaiproject.org/browse/SAK-42272>
Kind of like the tool you did for the current Tsugi style guide.
/Chuck
|
I'd like to upgrade Tsugi to use Bootstrap version 4.5.0. This version is a major rewrite from v3, so many aspects of Tsugi will need to be updated. https://getbootstrap.com/docs/4.5/migration/
I'm not sure the best way to avoid breaking Tsugi tools as they may rely on or assume that Bootstrap 3 is included and piggy-back off of the styling. Any suggestions are welcome.
The text was updated successfully, but these errors were encountered: