Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to support Fluent Assertions and xunit? #34

Open
iron9light opened this issue Jul 30, 2019 · 5 comments
Open

Is it possible to support Fluent Assertions and xunit? #34

iron9light opened this issue Jul 30, 2019 · 5 comments

Comments

@iron9light
Copy link
Contributor

Is it possible to support Fluent Assertions and xunit?

@twenzel
Copy link
Owner

twenzel commented Jul 30, 2019

Do you mean if it's possible to use those within the Demystify.Everything projects? FluentAssertions for sure. XUnit is already used.

@iron9light
Copy link
Contributor Author

iron9light commented Jul 30, 2019

No, I mean when someone using FluentAssertions, xUnit or any other unit tests framework, make the output stack tracing info of exception Demystified.
I think unit test is a key use case that people will care about the Exception and stack trace info.

@cocowalla
Copy link

Just wanted to +1 this - Demystify makes async stack traces soooo much easier to read when diagnosing xUnit unit test failures.

I think this might be possible by creating a customised XunitTestInvoker (like this), and then using a TestFrameworkDiscovererAttribute to override the behaviour of [Fact] and [Theory] - there's an example doing that here (the purpose was fo DI, but the principal is the same).

@twenzel
Copy link
Owner

twenzel commented Dec 28, 2021

@cocowalla Is upgrading to .NET Core 3.1 + an option? Because Ben Adams has fixed the async stack traces in .NET Core 3.1.

@cocowalla
Copy link

@cocowalla Is upgrading to .NET Core 3.1 + an option? Because Ben Adams has fixed the async stack traces in .NET Core 3.1.

I'm on dotnet 6 now, but I think I was on dotnet 5 at the time of that comment - where Demystify was still an improvement over the standard async stack trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants