Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open to cutting a 4.2.8 release? #1931

Closed
jamesbraza opened this issue Feb 6, 2024 · 13 comments
Closed

Open to cutting a 4.2.8 release? #1931

jamesbraza opened this issue Feb 6, 2024 · 13 comments

Comments

@jamesbraza
Copy link
Contributor

Are you open to cutting a new release (for mypy==1.8)?

django-stubs[compatible-mypy]==4.2.7 is pinned to mypy==1.7: https://github.com/typeddjango/django-stubs/blob/4.2.7/setup.py#L35, but the current master is not

@sobolevn
Copy link
Member

sobolevn commented Feb 7, 2024

It will be 5.0.0, I guess 🤔

@jamesbraza
Copy link
Contributor Author

Oh if it was a bugfix version bump, I am okay with requesting it 🤓 , but I don't want to rush a major version bump. If it's a major version bump, that would be up to your own choice in timing

@meshy
Copy link
Contributor

meshy commented Feb 8, 2024

Is there an appetite for back-fixing other bug fixes? It'd be great to have #1913 in an earlier version too!

@aleksanb
Copy link
Contributor

looking forward to a release here as well.

@intgr
Copy link
Collaborator

intgr commented Feb 14, 2024

but I don't want to rush a major version bump. If it's a major version bump, that would be up to your own choice in timing

Yep it would be 5.0.0. But the major version bump is just to stay in sync with Django version numbers. It shouldn't be significantly more complex than a typical release for us.

It's more that I've been absent from this project lately and nobody else has stepped up to handle the release. I wrote more at #1493 (comment)

@sobolevn
Copy link
Member

I think that 5.0.0 should also drop 3.7 support, since it is EOL.

@intgr
Copy link
Collaborator

intgr commented Feb 19, 2024

We already dropped Python 3.7 in version 4.2.1 😄 https://github.com/typeddjango/django-stubs?tab=readme-ov-file#version-compatibility

@sobolevn
Copy link
Member

Sorry, I got confused.

3.8 is not supported by pre-commit anymore: https://github.com/typeddjango/django-stubs/actions/runs/7953898472/job/21710530911

But, we cannot drop it yet, since it is still a supported Python version.

@delfick
Copy link
Contributor

delfick commented Feb 19, 2024

that could be fixed by making it install pre-commit with a different version if the python version is less than a certain number https://pip.pypa.io/en/stable/reference/requirement-specifiers/

@sobolevn
Copy link
Member

@delfick PR is welcome :)

@delfick
Copy link
Contributor

delfick commented Feb 20, 2024

@sobolevn #1961 I believe it needs approval before we can see if CI works against that change

@jamesbraza
Copy link
Contributor Author

Since versions in django-stubs match Django, it seems the next release here is a major version bump to version 5. I am now realizing that the small version bump I requested in the OP will go against the Django version matching.

I can attain what I wanted by pinning requirements to the last commit https://github.com/typeddjango/django-stubs/tree/7564f79d8d1574dc642e80c215c9262d7fe15baf like so:

django-stubs-ext @ git+https://github.com/typeddjango/django-stubs.git@7564f79d8d1574dc642e80c215c9262d7fe15baf#subdirectory=ext  # Matching django-stubs
django-stubs[compatible-mypy] @ git+https://github.com/typeddjango/django-stubs.git@7564f79d8d1574dc642e80c215c9262d7fe15baf  # For mypy 1.8

As shared above, there is a django-stubs compatibility with Django 5 issue tracker at #1493, so closing this out in favor of that.

@intgr
Copy link
Collaborator

intgr commented Mar 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants