Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feed timestamps are incorrect #47

Closed
aj-stein-nist opened this issue Sep 21, 2023 · 6 comments · Fixed by #61
Closed

RSS feed timestamps are incorrect #47

aj-stein-nist opened this issue Sep 21, 2023 · 6 comments · Fixed by #61
Assignees
Labels
bug Something isn't working

Comments

@aj-stein-nist
Copy link
Collaborator

aj-stein-nist commented Sep 21, 2023

Review the hugo configuration and relevant template information to determine why timestamps are always like below in the RSS XML when developing locally or when published on the production site.

<pubDate>Mon, 01 Jan 0001 00:00:00 +0000</pubDate>

Determine the root cause and draft a PR to properly generate timestamps for the production site build and for local development, if possible.

See #44 (comment) for more details about original report.

@aj-stein-nist aj-stein-nist moved this from Todo to Needs Triage in NIST OSCAL Work Board Sep 21, 2023
@aj-stein-nist aj-stein-nist added the bug Something isn't working label Sep 21, 2023
@Arminta-Jenkins-NIST Arminta-Jenkins-NIST moved this from Needs Triage to Further Analysis Needed in NIST OSCAL Work Board Oct 5, 2023
@Arminta-Jenkins-NIST
Copy link
Contributor

At 10/5 Triage Meeting:
@nikitawootten-nist - Setting must be enabled or system timestamp will be used resulting in the above mentioned timestamp.

@aj-stein-nist
Copy link
Collaborator Author

So I did checkout the default templates and @nikitawootten-nist is correct about how they work. I so have understanding of how this works for web pages (not RSS feeds) by looking at our custom layouts and how we get the LastMod or last modified date, using the GitInfo feature/plugin of hugo). I need to look more into how the PubDate should be set without modifying this default template and causing more churn, because the pages do properly pick up this date, maybe there is some clever way to make the PubDate and LastMod "equivalent" in hugo so RSS feeds pick it up too? More to follow.

@Arminta-Jenkins-NIST
Copy link
Contributor

At 10/12 Triage Meeting: There is a premade theme that @nikitawootten-nist uses. He will look at the theme to see if the timestamp is coming from the theme. @aj-stein-nist will coordinate with @nikitawootten-nist.

@aj-stein-nist
Copy link
Collaborator Author

@nikitawootten-nist is out of office today but I have been unable to use the docs and experimentation a method to fix this yet. I am dedicating tomorrow morning to look into this.

@nikitawootten-nist nikitawootten-nist moved this from Further Analysis Needed to Todo in NIST OSCAL Work Board Nov 1, 2023
@nikitawootten-nist nikitawootten-nist self-assigned this Nov 7, 2023
@nikitawootten-nist
Copy link
Collaborator

nikitawootten-nist commented Nov 8, 2023

After reviewing this issue in depth, I've determined this issue is much simpler and simultaneously more annoying to solve. Hugo defaults to a .pubDate of Mon, 01 Jan 0001 00:00:00 +0000 when .date is not set in the front-matter.

Fixing this issue will involve adding dates to all pages and making it a policy that date fields are added for new pages.

@nikitawootten-nist
Copy link
Collaborator

Closed via #61

@github-project-automation github-project-automation bot moved this from Under Review to Done in NIST OSCAL Work Board Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants