prettier:write complains about package.json when saved from Windows

[3esmit]

I am using WSL with Ubuntu. My console is Linux, but my editor is Windows.

When I edit package.json, I can run normally everything here, 'pnpm lint' or whatever. However, when I send to repository, CI lint complains about package.json having style issues.

When we see the diff, nothing changes, besides the last line of the code that is changed in an invisible character.

To workaround this, I open the file in a console editor inside WSL, and than save it.

I think this is a bug or configuration on prettier itself, as it should not matter what EOL are used, as Windows is able to interpret Linux files, and Linux is able to interpret Windows file.

It shouldn't warn for Windows EOL, unless there is a good reason for that.

[3esmit]

an workaround would be to add this to .gitattributes:

# Set the default behavior, in case people don't have core.autocrlf set.
* text=auto

# Explicitly declare text files you want to always be normalized and converted
# to native line endings on checkout.
*.c text
*.h text

# Declare files that will always have CRLF line endings on checkout.
*.json text eol=lf

# Denote all files that are truly binary and should not be modified.
*.png binary
*.jpg binary

[3esmit]

https://prettier.io/docs/en/options.html#end-of-line

[0x-r4bbit]

@3esmit Here's a PR that enforces line feeds in the git repository: #26

Following the recommendations by prettier:

If you want to make sure that your entire git repository only contains Linux-style line endings in files covered by Prettier:

1. Ensure Prettier’s endOfLine option is set to lf (this is a default value since v2.0.0)
2. Configure a pre-commit hook that will run Prettier
3. Configure Prettier to run in your CI pipeline using --check flag. If you use Travis > CI, set the autocrlf option to input in .travis.yml.
4. Add * text=auto eol=lf to the repo’s .gitattributes file. You may need to ask Windows users to re-clone your repo after this change to ensure git has not converted LF to CRLF on checkout.

With this we're checking off 1), 3) and 4).

I'll look into setting up the commit hook next.

[0x-r4bbit]

So git hooks are client-side (local) only.
Before we start adding additional dependencies to get hooks for everyone, can you try any of these options here and see if they actually work for you:

https://prettier.io/docs/en/precommit

You might want to try this on top of #26 also

[0x-r4bbit]

@3esmit how do we move forward here. Did you try any of the options?

[3esmit]

I am not sure. I have tried some but didnt seemed to work. It's difficult to diagnose this.

[0x-r4bbit]

Did you try installing a pre-commit hook?

[0x-r4bbit]

Closing this due to inactivity