Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance transfer estimateFee API with an "include fee" mode #10756

Open
JonRay15 opened this issue Feb 26, 2024 · 0 comments
Open

Enhance transfer estimateFee API with an "include fee" mode #10756

JonRay15 opened this issue Feb 26, 2024 · 0 comments
Labels
api fe-request A list of reasonably high value API change requests from front end

Comments

@JonRay15
Copy link

Issue

When users make a transfer now Console is calling estimateFee API to get this estimate.

The slight UX issue with this is that you cant set your transfer to "include fee" anymore, and therefore it isnt very clean or intuitive when you just want to "Use Max" because we dont actually know the max. Users just have to sort of trial and error a large amount that hopefully leaves enough balance over to cover the fee.

Request

Ideally the estimateFee API would have an input to allow you request "includeFee" mode, whereby if the user wanted to pay a total of say 100 VEGA the API would return the transfer size + fee that will total that amount.

This would then also support a "Use max" type function in the front end.

eg.

Normal Mode
FE submits amount X >> API returns the fee incurred Y

Include Fee mode
FE submits amount X >> API returns the fee incurred Y and the amount to transfer Z where X = Y + Z

@JonRay15 JonRay15 added api fe-request A list of reasonably high value API change requests from front end labels Feb 26, 2024
@JonRay15 JonRay15 changed the title Enhance estimateFee API with an "include fee" mode Enhance transfer estimateFee API with an "include fee" mode Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api fe-request A list of reasonably high value API change requests from front end
Projects
Status: No status
Development

No branches or pull requests

1 participant