Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters to the trade API #10908

Open
4 tasks
JonRay15 opened this issue Mar 15, 2024 · 1 comment
Open
4 tasks

Add filters to the trade API #10908

JonRay15 opened this issue Mar 15, 2024 · 1 comment
Labels
api fe-request A list of reasonably high value API change requests from front end

Comments

@JonRay15
Copy link

Request

Currently trades API only allows filtering by market, party, order, and datetime range.

We shoudl add filters for:

  • buyer
  • seller
  • aggressor
  • type

This would allow the Console to find closeout trades by filtering on TYPE_NETWORK_CLOSE_OUT_BAD and buyer = "network".

I added the other filters because while we're in here it makes sense to add these so we have more options in future.

@JonRay15 JonRay15 added api fe-request A list of reasonably high value API change requests from front end labels Mar 15, 2024
@gordsport gordsport moved this to Todo in Core Kanban Mar 15, 2024
@gordsport gordsport added this to the 🏛️ Colosseo milestone Mar 15, 2024
@EVODelavega
Copy link
Contributor

Just a point of clarification: the party filter is currently implemented as finding trades with said parties both as buyer and seller, do we want to keep that as is, replace with distinct buyer/seller fields, or support both (e.g.: find all trades involving party X -> use parties, find all trades where party X was the buyer -> user buyer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api fe-request A list of reasonably high value API change requests from front end
Projects
Status: Todo
Development

No branches or pull requests

4 participants