-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jshint? #40
Comments
That would probably mean including jshint in the build itself, which would be a major addition for what seems like a smaller number of use cases. |
To clarify- I was meaning before eval, not before eval(). |
Enforcement of ESLint "Standard" ruleset with the exception of "semi" set to ["error", "always"].
@Gpeschke Strict enforcement of ESLint "Standard" is now part of the GitHub action workflow. |
Hmmm... still seems like we are talking bout separate things. I'm talking about within twine, when you are developing a story, it'd be nice to be able to lint. |
@Gpeschke: We were originally talking about the same thing, I think. For you to be able to lint in the editor, either Twine 2 would have to add it (which it probably won't) or Snowman would have to carry and maintain the functionality (which is a huge hassle for little gain). I'd like to eventually be able to add #20 at some point, but linting seems a long way off unless Twine 2 adds it for editing Story JavaScript. If you want linting in your code, I'd recommend using something like TweeGo or my own Extwee and working on JavaScript outside of the browser or application. Linting could easily be part of the compiling process through ESLint or other tools. |
I know it's probably a lot to ask, but it'd be SUPER cool if we could integrate jshint- running it on the javascript code before eval, then if the code errors, spitting out what jshint found.
The text was updated successfully, but these errors were encountered: