Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Update-specific messages, and install-only INSTALL.msg #559

Open
0x5c opened this issue Jun 4, 2023 · 0 comments
Open

[RFC] Update-specific messages, and install-only INSTALL.msg #559

0x5c opened this issue Jun 4, 2023 · 0 comments

Comments

@0x5c
Copy link

0x5c commented Jun 4, 2023

As is currently stands, the only way to signal a breaking change in an update is to mention it in INSTALL.msg. This shows the message for any updates, and even for fresh installations. On top of that, messages relevant to only a fresh installation are shown for updates too.

The result is that most messages shown in an average transaction aren't relevant in any way to the transaction, which causes users to learn to tune out the messages.

I propose adding messages that are specific to an update (or rather, specific to a breaking change), and changing the existing INSTALL.msg to be only shown for fresh installs or reinstalls.

This would require storage of the update messages, along with the package version containing the breaking change. One such update message would only be shown if the package is being updated, and if the currently installed version is lower than the message's version. XBPS should be able to show as many update messages as relevant to a particular transaction.

The logic for when INSTALL.msg is shown would be changed to not show the message for updates.

I'm not familiar enough with XBPS internals to know what would need to change implementation-wise.

On xbps-src's end this would probably look like additional UPDATE-<ver>.msg files in a package's directory, along with changes in the xbps-create invocation. A good number of packages would need to be updated to use UPDATE messages.

EDIT: I realised a big flaw in my pick of what version should be recorded along with an UPDATE message, so I switched it to be the first version that breaks (message shows for any currently installed version lower than it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant