-
Notifications
You must be signed in to change notification settings - Fork 0
/
0001-prefs-always-prompt-for-download-directory-by-defaul.patch
45 lines (37 loc) · 1.87 KB
/
0001-prefs-always-prompt-for-download-directory-by-defaul.patch
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
From 47d1f6b943db2b5867acef6843f9a057174e620b Mon Sep 17 00:00:00 2001
From: Jan Engelhardt <jengelh@inai.de>
Date: Fri, 13 Feb 2015 01:04:21 +0100
Subject: [PATCH] prefs: always prompt for download directory by default
If the user opens a link, one of two things might happen. The URI
resolves to a "web page" and will be displayed, then everything is
good. Or it has a MIME type like application/* or so that causes the
browser to consider it a file download instead.
In that case, one of two things might happen. The browser may display
a dialog box asking explicitly for an action, then everything is
good. Or it does not and instead readily stores the file on disk.
(Modern browsers also download the file in the background when waiting
for the dialog box confirmation, but that is a separate tuning knob.)
When the file is chosen to be immediately stored on disk without user
interaction, the visual feedback for this may be rather miniscule.
And then, you have to open a terminal or file manager again just to
move the file to the location you wanted it to be in in the first
place.
TLDR: Do not let files sneak onto the disk too easily.
---
chrome/browser/download/download_prefs.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/chrome/browser/download/download_prefs.cc b/chrome/browser/download/download_prefs.cc
index c6b31c58d679..dd1efc3e84a6 100644
--- a/chrome/browser/download/download_prefs.cc
+++ b/chrome/browser/download/download_prefs.cc
@@ -204,7 +204,7 @@ void DownloadPrefs::RegisterProfilePrefs(
user_prefs::PrefRegistrySyncable* registry) {
registry->RegisterBooleanPref(
prefs::kPromptForDownload,
- false,
+ true,
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
registry->RegisterStringPref(prefs::kDownloadExtensionsToOpen, std::string());
registry->RegisterBooleanPref(prefs::kDownloadDirUpgraded, false);
--
2.14.3