Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced compound_l1_mssim_loss #143

Open
Daval-G opened this issue Aug 26, 2021 · 1 comment
Open

Misplaced compound_l1_mssim_loss #143

Daval-G opened this issue Aug 26, 2021 · 1 comment

Comments

@Daval-G
Copy link

Daval-G commented Aug 26, 2021

The function named compound_l1_mssim_loss is currently defined in models/training/compile.py which is not really intuitive. I would expect it to be defined along with other loss functions at evaluate.metrics.tf_metrics.py or simply in evaluate.metrics.

@zaccharieramzi
Copy link
Owner

Good point. I would rather have a new file, losses.py where we could define this, because the compound mssim is not really a metric per se.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants