The sorting had ensured that sections with the tag catch-plain-hostna…

…mes were prioritized. This should only happen if there are no destinations in the section, otherwise the hostname overlap check will no longer help.

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "paccreator"
-version = "0.2.1"
+version = "0.2.2"
 dynamic = ["dependencies"]
 authors = [
     { name = "Heiko Schmidt", email = "73h@gmx.net" },

src/paccreator/helpers.py

@@ -60,4 +60,6 @@ def get_target_type(target: str) -> TargetType:
 
 
 def sort_by_rating(proxy):
-    return min([t.rating for t in proxy.targets])
+    if len(proxy.targets) == 1 and TargetType.PLAIN_HOSTNAME in [t.type for t in proxy.targets]:
+        return TargetType.PLAIN_HOSTNAME.value;
+    return min([t.rating for t in proxy.targets if t.type != TargetType.PLAIN_HOSTNAME])

src/tests/helpers_test.py

@@ -61,3 +61,19 @@ def test_sort_by_rating(self):
         self.assertEqual(config.proxies[0].targets[0].rating, 4)
         config.proxies.sort(key=sort_by_rating)
         self.assertEqual(config.proxies[0].route, "B")
+
+    def test_sort_by_rating_with_plain_hostname_tag(self):
+        config = {"proxies": [{"route": "A", "tags": ["catch-plain-hostnames"], "targets": [".example.com"]},
+                              {"route": "B", "targets": ["foo.example.com"]}]}
+        config = PacCreatorConfig(**config)
+        config.recognize_overlaps()
+        config.proxies.sort(key=sort_by_rating)
+        self.assertEqual(config.proxies[0].route, "B")
+
+    def test_sort_by_rating_with_plain_hostname_tag_in_exclusive_section(self):
+        config = {"proxies": [{"route": "A", "tags": ["catch-plain-hostnames"], "targets": []},
+                              {"route": "B", "targets": ["foo.example.com"]}]}
+        config = PacCreatorConfig(**config)
+        config.recognize_overlaps()
+        config.proxies.sort(key=sort_by_rating)
+        self.assertEqual(config.proxies[0].route, "A")