Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 0.25 RYF config #85

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

anton-seaice
Copy link

@anton-seaice anton-seaice commented Apr 11, 2024

Contributes to #17

This adds 0.25 degree RYF config

@anton-seaice
Copy link
Author

I don't understand this failure:

AssertionError: Expect collate executable set to mppnccombine-fast

It's set to
exe: /g/data/vk83/apps/spack/0.20/release/linux-rocky8-x86_64/intel-19.0.5.281/mom5-git.2023.11.09=2023.11.09-ewcdbrfukblyjxpkhd3mfkj4yxfolal4/bin/mppnccombine.spack

Which I believe is correct?

@aidanheerdegen
Copy link
Member

Which I believe is correct?

#68 (comment)

@anton-seaice anton-seaice marked this pull request as draft April 11, 2024 06:29
@anton-seaice anton-seaice marked this pull request as ready for review April 17, 2024 05:48
@anton-seaice anton-seaice changed the title Updates for 0.25 config Updates for 0.25 RYF config Apr 17, 2024
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few things to fix.

config.yaml Outdated
@@ -51,8 +56,8 @@ submodels:
model: cice5
exe: /g/data/vk83/apps/spack/0.20/release/linux-rocky8-x86_64/intel-19.0.5.281/cice5-git.2023.10.19=2023.10.19-rh3xfkrgajya3ghtliacuhlx3pgvrzqs/bin/cice_auscom_1440x1080_48x40_480p.exe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exe: /g/data/vk83/apps/spack/0.20/release/linux-rocky8-x86_64/intel-19.0.5.281/cice5-git.2023.10.19=2023.10.19-rh3xfkrgajya3ghtliacuhlx3pgvrzqs/bin/cice_auscom_1440x1080_48x40_480p.exe
exe: /g/data/vk83/apps/spack/0.20/release/linux-rocky8-x86_64/intel-19.0.5.281/cice5-git.2023.10.19=2023.10.19-v3zncpqjj2gyseudbwiudolcjq3k3leo/bin/cice_auscom_1440x1080_48x40_480p.exe

Update to the latest ACCESS-OM2 release.

config.yaml Show resolved Hide resolved
metadata.yaml Outdated
but with many improvements.\nInitial conditions are WOA13v2 potential temperature
and practical salinity.\nRun with JRA55-do v1.4.0 RYF9091 (1 May 1990 - 30 April
1991) repeated forcing\nwith all solid runoff converted to liquid runoff with no
heat transfer.\nSpin up starts from a nominal year of 1 Jan 1900."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the 1 degree description.

anton-seaice and others added 2 commits April 18, 2024 16:41
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
@anton-seaice anton-seaice marked this pull request as draft April 18, 2024 06:44
@aidanheerdegen aidanheerdegen self-requested a review April 18, 2024 06:47
aidanheerdegen
aidanheerdegen previously approved these changes Apr 18, 2024
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-seaice
Copy link
Author

LGTM

Wrong answer ! :)

@anton-seaice
Copy link
Author

I think this might be complete @aidanheerdegen

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for catching the catch I didn't.

@aidanheerdegen aidanheerdegen merged commit 63f0795 into dev-025deg_jra55_ryf Apr 18, 2024
8 checks passed
@aidanheerdegen aidanheerdegen deleted the update-025deg_jra55_ryf_iss17 branch April 18, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants