Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement no_std serialization for NaiveTime #106

Merged
merged 2 commits into from
Aug 27, 2023

Conversation

0xf4lc0n
Copy link

This PR resolves #105.

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.35% ⚠️

Comparison is base (c7ba32e) 78.60% compared to head (02ccb90) 77.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   78.60%   77.26%   -1.35%     
==========================================
  Files          33       33              
  Lines        1206     1227      +21     
==========================================
  Hits          948      948              
- Misses        258      279      +21     
Files Changed Coverage Δ
src/sentences/gga.rs 54.16% <0.00%> (-35.49%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@elpiel elpiel merged commit 4111cc5 into AeroRust:main Aug 27, 2023
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#derive[Serialize] for chrono::NaiveTime uses collect_str which cannot be used in no_std
2 participants