ci(restore-node): corepack enable to accommodate Endo

[michaelfig]

Description

Although nightly Endo integration tests have not yet been fully vetted, this PR does at least prevent the following error:

/home/runner/endo /home/runner/work/agoric-sdk/agoric-sdk
Switched to a new branch 'lerna-publish'
error This project's package.json defines "packageManager": "yarn@4.1.1". However the current global version of Yarn is 1.22.22.

Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from 16.9 and 14.19.

Security Considerations

CI only.

Scaling Considerations

No impact.

Documentation Considerations

n/a, internal CI configuration.

Testing Considerations

Tested nightly against latest Endo repository.

Upgrade Considerations

n/a

[michaelfig]

Looks like a familar failure. How did we fix this last time?

start voteLatestProposalAndWait()
waiting for block...
1
block produced
done
Latest proposal: 13
waiting for block...
1
block produced
done
Error: rpc error: code = Unknown desc = rpc error: code = Unknown desc = account sequence mismatch, expected 60, got 59: incorrect account sequence [agoric-labs/cosmos-sdk@v0.46.16-alpha.agoric.2.1/x/auth/ante/sigverify.go:269] With gas wanted: '18446744073709551615' and gas used: '38588' : unknown request
Usage:
  agd tx gov deposit [proposal-id] [deposit] [flags]

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	f2f015b
Status:	✅  Deploy successful!
Preview URL:	https://d5519440.agoric-sdk.pages.dev
Branch Preview URL:	https://mfig-ci-corepack.agoric-sdk.pages.dev

View logs

[michaelfig]

I pinged you, @turadg, since I think you have a better grasp of corepack enable interacting with the ghcr.io/agoric/agoric-3-proposals:latest docker image that the getting-started on which the tests are based.

I don't yet see what's different with the getting-started (registry/npm) (consistently passes) vs. (registry/yarn) (consistently fails). I'd be happy to peer on this, but it isn't urgent.

[michaelfig]

I don't yet see what's different with the getting-started (registry/npm) (consistently passes) vs. (registry/yarn) (consistently fails).

... and just as I reran the CI, all the getting-started tests are passing. Flake?

[turadg]

... and just as I reran the CI, all the getting-started tests are passing. Flake?

Looks like the passing one never pulled the Endo repo.
failing has,

Run actions/checkout@v4
Syncing repository: agoric/endo

but the passing one doesn't. Maybe job re-run doesn't get the right value here

[turadg]

There's more to do but I think this change is good

[turadg]

I think this is the right place for corepack enable. I wish I'd thought of it when adding https://github.com/Agoric/agoric-sdk/blob/master/.github/workflows/integration.yml#L247

I think we can remove the latter. Also I don't think the shell property is necessary.

[michaelfig]

I think we can remove the latter.

Done.

Also I don't think the shell property is necessary.

I've found that shell: bash is necessary for every run: xxx step because restore-node/action.yml is a composite action, not a workflow. See the Github documentation that describes shell: in the composite actions metadata syntax section.